Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test according to main PR #336

Merged
merged 12 commits into from
Apr 12, 2024
Merged

Update test according to main PR #336

merged 12 commits into from
Apr 12, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Feb 6, 2024

Main PR

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Feb 6, 2024

PR Summary

  • Enhanced Testing Features in CommandTest.php
    Adding new parameters to the testing method will allow for more granular testing and better verification of results. For instance, the $expectedValues parameter will enable us to specify what the test output should be, and the $expectedCount parameter will allow us to specify how many items we expect in the result. These enhancements can prevent potential errors as we continue to build and improve upon the product's capabilities.

  • Improved Query Testing in QueryBuilderTest.php
    Introducing new parameters to the QueryBuilder testing method further expands our testing capabilities, notably in the generation and execution of database queries. The $params parameter allows us to input various conditions for generating our queries more dynamically and flexibly, and the $expectedSql parameter lets us dictate the desired SQL string the method should return. This ensures our database querying is reliable and efficient, thus protecting data integrity and application performance.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a023a09) to head (fd06ade).
Report is 3 commits behind head on master.

❗ Current head fd06ade differs from pull request most recent head 689cccd. Consider uploading reports for the commit 689cccd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #336   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       241       257   +16     
===========================================
  Files             16        18    +2     
  Lines            694       745   +51     
===========================================
+ Hits             694       745   +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need line in changelog

rector.php Show resolved Hide resolved
@vjik vjik merged commit fc7567b into master Apr 12, 2024
2 of 3 checks passed
@vjik vjik deleted the fix-update-with-expressions branch April 12, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants