Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test according to main PR #289

Merged
merged 11 commits into from
Apr 12, 2024
Merged

Update test according to main PR #289

merged 11 commits into from
Apr 12, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Feb 6, 2024

Main PR

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Feb 6, 2024

PR Summary

  • Updated Method Signature in CommandTest.php
    The testUpdate method signature within CommandTest.php has been amended. It now allows for an extra input, $expectedValues, which is an array type. Beyond this, an optional parameter has been included, $expectedCount, which is an integer type.

  • Edited Method Signature in QueryBuilderTest.php
    There has been a modification with the testUpdate method signature of QueryBuilderTest.php. An extra parameter $params of an array type has been added, along with an optional parameter $expectedParams of array type as well.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (9d30cf9) to head (f83b888).
Report is 3 commits behind head on master.

❗ Current head f83b888 differs from pull request most recent head e0c2aee. Consider uploading reports for the commit e0c2aee to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
+ Coverage     98.42%   98.46%   +0.04%     
- Complexity      329      339      +10     
============================================
  Files            19       21       +2     
  Lines          1015     1043      +28     
============================================
+ Hits            999     1027      +28     
  Misses           16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need line in changelog

rector.php Show resolved Hide resolved
@vjik vjik merged commit 4a95c6b into master Apr 12, 2024
2 of 3 checks passed
@vjik vjik deleted the fix-update-with-expressions branch April 12, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants