Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Dsn class #323

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Refactor Dsn class #323

merged 2 commits into from
Oct 18, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Oct 18, 2024

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues -

@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (d43b696) to head (4ff3372).

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #323   +/-   ##
=========================================
  Coverage     98.50%   98.51%           
  Complexity      340      340           
=========================================
  Files            23       23           
  Lines          1072     1074    +2     
=========================================
+ Hits           1056     1058    +2     
  Misses           16       16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 877127f into master Oct 18, 2024
2 checks passed
@Tigrov Tigrov deleted the refactor-dsn branch October 18, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tigrov @samdark