Refactor ColumnDefinitionBuilder
#327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
============================================
- Coverage 98.50% 98.50% -0.01%
Complexity 336 336
============================================
Files 23 23
Lines 1073 1072 -1
============================================
- Hits 1057 1056 -1
Misses 16 16 ☔ View full report in Codecov by Sentry. |
samdark
approved these changes
Nov 17, 2024
| @@ -12,6 +12,9 @@ final class ColumnDefinitionBuilder extends AbstractColumnDefinitionBuilder | |||
| { | |||
| protected const AUTO_INCREMENT_KEYWORD = 'AUTOINCREMENT'; | |||
|
|
|||
| protected const GENERATE_UUID_EXPRESSION = | |||
| "(unhex(format('%016X', random() & 0xFFFFFFFFFFFF4FFF | 0x4000) || format('%016X', random() & 0xBFFFFFFFFFFFFFFF | 0xB000000000000000)))"; | |||
There was a problem hiding this comment.
Valid UUID v4.
Also there is randomblob(16) function but it is not valid UUID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rellated PR
AbstractColumnDefinitionBuilderdb#901