Fix bug with sub-query with alias as table name

yiisoft · Sep 25, 2023 · d9d1ee2 · d9d1ee2
1 parent b259119
commit d9d1ee2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Schema/Quoter.php b/src/Schema/Quoter.php
@@ -175,7 +175,7 @@ function ($matches) {
 
     public function quoteTableName(string $name): string
     {
-        if (str_starts_with($name, '(') && str_ends_with($name, ')')) {
+        if (str_starts_with($name, '(')) {
             return $name;
         }
 

diff --git a/tests/Db/Schema/QuoterTest.php b/tests/Db/Schema/QuoterTest.php
@@ -102,4 +102,12 @@ public function testQuoteSqlWithTablePrefix(): void
 
         $this->assertSame('SELECT * FROM `prefix_table`', $quoter->quoteSql($sql));
     }
+
+    public function testQuoteTableNameWithQueryAlias()
+    {
+        $quoter = new Quoter('`', '`', 'prefix_');
+        $name = '(SELECT * FROM table) alias';
+
+        $this->assertSame($name, $quoter->quoteTableName($name));
+    }
 }