Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix phpdoc and changelog #733

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Minor fix phpdoc and changelog #733

merged 3 commits into from
Jul 31, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Jul 30, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4434b83) 89.59% compared to head (ba61785) 89.59%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #733   +/-   ##
=========================================
  Coverage     89.59%   89.59%           
  Complexity     1375     1375           
=========================================
  Files            67       67           
  Lines          3382     3382           
=========================================
  Hits           3030     3030           
  Misses          352      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@what-the-diff
Copy link

what-the-diff bot commented Jul 30, 2023

PR Summary

  • Added a new feature in CHANGELOG.md
    A new debugging tool (feature Split debug #617 by @xepozz) has been added to a module (yiisoft/yii-debug). This tool will help to identify and solve problems more effectively.

  • Enhanced two features in CHANGELOG.md
    Both feature Split debug #617 and Minor fix phpdoc and changelog #733 have been refined to improve system annotation related to a specific function (ConnectionInterface::transaction() method) of the software - this was carried out by @xepozz and @vjik. This optimization would offer clearer guidelines to other developers when using this module.

  • Update to the transaction() method in the ConnectionInterface.php file
    The "transaction()" function details in the 'ConnectionInterface.php' file have been modified to enhance the code's clarity. This includes additional tags for a parameter ($closure), and adjustment to the function return type (from nonexistent to being able to return various kinds of data). These changes will allow for more flexibility when using the function.

@vjik vjik requested a review from a team July 30, 2023 07:14
@vjik vjik added the status:code review The pull request needs review. label Jul 30, 2023
@vjik vjik merged commit c5aa0b1 into master Jul 31, 2023
164 of 169 checks passed
@vjik vjik deleted the fix branch July 31, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants