-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Quoter
#756
Refactor Quoter
#756
Conversation
PR Summary
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #756 +/- ##
=========================================
Coverage 99.73% 99.73%
+ Complexity 1269 1268 -1
=========================================
Files 63 63
Lines 3038 3045 +7
=========================================
+ Hits 3030 3037 +7
Misses 8 8
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Need add info to changelog only.
use function
blockstr_contains()
withstr_starts_with()
quoteSql()
for sql containing table with prefix (test)getTableNameParts()
for cases with different quotes for tables and columns (test)quoteTableName()
for sub-query with alias (test)