Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ColumnDefinitionParser::extraInfo() method #900

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 17, 2024

It will be used in alterColumn() method

Q A
Is bugfix?
New feature? ✔️/❌
Breaks BC?
Fixed issues #854

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.29%. Comparing base (3167625) to head (f1f7248).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Syntax/ColumnDefinitionParser.php 70.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #900      +/-   ##
============================================
- Coverage     99.60%   93.29%   -6.32%     
- Complexity     1539     1544       +5     
============================================
  Files            81       81              
  Lines          3800     3818      +18     
============================================
- Hits           3785     3562     -223     
- Misses           15      256     +241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Nov 17, 2024
@Tigrov Tigrov requested a review from a team November 17, 2024 04:11
@Tigrov Tigrov merged commit ba043b6 into master Nov 17, 2024
56 of 58 checks passed
@Tigrov Tigrov deleted the improve-column-definition-parser branch November 17, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants