Revert all PR for "Data providers perform unnecessary COUNT queries that negatively affect performance".

[terabytesoftw]

PRs Revert:

• Revert "Remove cache \yii\data\ActiveDataProvider::prepareTotalCount(…) (#20206)" #20223
• Revert "Fix #20175: Fix bad result for pagination when used with GridView." #20222
• Revert "Fix #20055: Fix Response header X-Pagination-Total-Count is always 0". #20225
• fix: #20002 optimize head request on serializeDataProvider #20007

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues	#20213

[codecov]

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.93%. Comparing base (5f5ef64) to head (626b0ca).

Files	Patch %	Lines
framework/rest/Serializer.php	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #20226      +/-   ##
============================================
- Coverage     64.98%   64.93%   -0.06%     
+ Complexity    11391    11389       -2     
============================================
  Files           430      430              
  Lines         36919    36911       -8     
============================================
- Hits          23993    23969      -24     
- Misses        12926    12942      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marcovtwout]

@terabytesoftw The 4 lines mensioned in the opening posts are exactly the ones that need to be removed, but it looks like this PR is currently incomplete? I don't see all the expected changes in this PR (except for the CHANGELOG entries for 2.0.50 that should not be reverted)

[terabytesoftw]

@terabytesoftw The 4 lines mensioned in the opening posts are exactly the ones that need to be removed, but it looks like this PR is currently incomplete? I don't see all the expected changes in this PR (except for the CHANGELOG entries for 2.0.50 that should not be reverted)

Could you explain to me what else is missing, i reverted all the PRs, compared with the 2.0.49.x branch and i don't see any differences. @marcovtwout

[marcovtwout]

@terabytesoftw It's not easy to read from all the separate diffs. Here's the things I noticed manually:

• the removed use Yii statements in many files from https://github.com/yiisoft/yii2/pull/20222/files#diff-2d59a53b455d32e67467aa1a4036d737a3564d6f65203e405ee3fc8c251787de, or did you leave these removed on purpose?
• one CHANGELOG line can be removed, since 2.0.50.1 is not released yet: https://github.com/yiisoft/yii2/blob/master/framework/CHANGELOG.md?plain=1#L10
• new CHANGELOG line can be added for 2.0.50.1 that details the changes you are making

I agree a final comparison for all relevant files with 2.0.49.x is a good thing (but double check any other relevant changes to those files from other PR's are not reverted).

[terabytesoftw]

• the removed use Yii statements in many files from https://github.com/yiisoft/yii2/pull/20222/files#diff-2d59a53b455d32e67467aa1a4036d737a3564d6f65203e405ee3fc8c251787de, or did you leave these removed on purpose?

Yes, i removed it, since it is a change that does not affect.

• one CHANGELOG line can be removed, since 2.0.50.1 is not released yet: https://github.com/yiisoft/yii2/blob/master/framework/CHANGELOG.md?plain=1#L10

fixed.

• new CHANGELOG line can be added for 2.0.50.1 that details the changes you are making

fixed

Thanks applied all the corrections.

@marcovtwout

[samdark]

Thanks.