Fix #20232: Fix regression introduced in GHSA-cjcc-p67m-7qxm while attaching behavior defined by __class array key
#20232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…havior defined by `__class` array key
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20232 +/- ##
=========================================
Coverage 64.93% 64.93%
- Complexity 11389 11391 +2
=========================================
Files 430 430
Lines 36912 36912
=========================================
Hits 23970 23970
Misses 12942 12942 ☔ View full report in Codecov by Sentry. |
bizley
approved these changes
Jul 25, 2024
samdark
approved these changes
Jul 25, 2024
samdark
changed the title
__class keyGHSA-cjcc-p67m-7qxm while attaching behavior defined by __class array key
|
I'm afraid that this restores vulnerability fixed in 628d406. Now you can pass behavior as |
|
Will it help if we swap condition so |
|
Probably, but IMO it should not even check for |
|
Ok, I'll submit a new version tomorrow. |
erickskrauch
added a commit
to erickskrauch/yii2
that referenced
this pull request
Aug 14, 2024
mtangoo
added a commit
that referenced
this pull request
Sep 14, 2024
Fix restored vulnerability after #20232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just spotted this problem after upgrading to the latest version to fix CVE.
Context: configuration via
Yii2::createObject()allows creating an object via__classdefinition. But after the changes in the 628d406, this option was forgotten. This PR restores forgotten behavior.