Pending changes

yireo · Oct 16, 2023 · 7efd752 · 7efd752
1 parent f9e9307
commit 7efd752
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ComponentCollector/AbstractComponentCollector.php b/ComponentCollector/AbstractComponentCollector.php
@@ -31,7 +31,8 @@ protected function findComponentsByModuleName(string $content, bool $hardRequire
         if (!preg_match_all('/([A-Za-z0-9]+)_([A-Za-z0-9]+)::/', $content, $matches)) {
             return [];
         }
-
+
+        $components = [];
         foreach ($matches[0] as $matchIndex => $match) {
             $moduleName = $matches[1][$matchIndex] . '_' . $matches[2][$matchIndex];
             $components[] = $this->componentFactory->createByModuleName($moduleName, $hardRequirement);

diff --git a/Test/Integration/ComponentDetector/ModuleXmlComponentDetectorTest.php b/Test/Integration/ComponentDetector/ModuleXmlComponentDetectorTest.php
@@ -4,6 +4,7 @@
 
 use Magento\Framework\App\ObjectManager;
 use PHPUnit\Framework\TestCase;
+use Yireo\ExtensionChecker\ComponentDetector\ModuleXmlComponentDetector;
 use Yireo\ExtensionChecker\ComponentDetector\PhpClassComponentDetector;
 use Yireo\ExtensionChecker\Test\Integration\Behaviour\AssertContainsByComponentName;
 
@@ -13,7 +14,7 @@ class ModuleXmlComponentDetectorTest extends TestCase
 
     public function testGetComponentsByModuleName()
     {
-        $componentDetector = ObjectManager::getInstance()->get(PhpClassComponentDetector::class);
+        $componentDetector = ObjectManager::getInstance()->get(ModuleXmlComponentDetector::class);
         $components = $componentDetector->getComponentsByModuleName('Magento_Catalog');
         $this->assertNotEmpty($components);
         $this->assertContainsByComponentName('Magento_Checkout', $components);