Skip to content

Commit

Permalink
Release
Browse files Browse the repository at this point in the history
  • Loading branch information
jissereitsma committed Oct 22, 2024
1 parent 56f094f commit 6c888c3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [3.9.10] - 22 October 2024
### Fixed
- Only trigger `view_cart` event when there are items in the cart
- Allow multiple GTM IDs
- Fix GTM URL

## [3.9.9] - 22 October 2024
### Fixed
Expand Down
5 changes: 3 additions & 2 deletions Config/Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -209,13 +209,14 @@ public function hasServerSideTracking(): bool
*/
public function getGoogleTagmanagerUrl(): string
{
$default = 'https://www.googletagmanager.com';
if (false === $this->hasServerSideTracking()) {
return '';
return $default;
}

return $this->getModuleConfigValue(
'serverside_gtm_url',
'https://www.googletagmanager.com'
$default
);
}

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "yireo/magento2-googletagmanager2",
"version": "3.9.9",
"version": "3.9.10",
"license": "OSL-3.0",
"type": "magento2-module",
"homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2",
Expand Down

0 comments on commit 6c888c3

Please sign in to comment.