Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fallback to source image if it doesn't exists #74

Merged
merged 1 commit into from
Apr 2, 2021
Merged

fallback to source image if it doesn't exists #74

merged 1 commit into from
Apr 2, 2021

Conversation

gtlt
Copy link
Contributor

@gtlt gtlt commented Mar 30, 2021

Proposing issue #70 fix to fallback to source image if it does not exists.

@gtlt gtlt mentioned this pull request Mar 30, 2021
Open
@jissereitsma jissereitsma merged commit ae9afad into yireo:master Apr 2, 2021
@jissereitsma
Copy link
Contributor

Thanks @gtlt - this looked simple enough to merge right away. Your addition simply follows the logical flow I created initially, so to the very least this will work fine in all cases. Whether it fixes the issue #70 completely as well, is something we'll see later.

Releasing in 1 minute.

@jissereitsma
Copy link
Contributor

Version 0.10.6 is now released. Many thanks @gtlt !!

@gtlt
Copy link
Contributor Author

gtlt commented Apr 2, 2021 •
edited
Loading

I tried it in production mode but saw some strange behavior. It doesn't look to always fallback, possibly due to magento/varnish/cdn caching. I fear it is not enough, will try to look into it this weekend.
It looks good too in production mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtlt @jissereitsma