Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tagPosition parameter #1461

Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat: Add tagPosition parameter #1461

merged 1 commit into from
Nov 28, 2024
+60 −3

Conversation

resessh
Copy link
Contributor

@resessh resessh commented Nov 27, 2024

This fixes #1296

@resessh resessh force-pushed the enable-pass-tag-position branch 2 times, most recently from 244b44a to c94208a Compare November 28, 2024 02:51
ymmooot
ymmooot approved these changes Nov 28, 2024
View reviewed changes
Copy link
Owner

@ymmooot ymmooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cypress Cypress
Copy link

cypress bot commented Nov 28, 2024 •
edited
Loading

nuxt-jsonld    Run #1176

Run Properties:  status check passed Passed #1176  •  git commit 9f7a604cd9 ℹ️: Merge 65dd6c3e558a4a5a70b7af432e8424e2055cea05 into 8f996a0f79efadd9511c94408dca...
Project nuxt-jsonld
Branch Review enable-pass-tag-position
Run status status check passed Passed #1176
Run duration 00m 06s
Commit git commit 9f7a604cd9 ℹ️: Merge 65dd6c3e558a4a5a70b7af432e8424e2055cea05 into 8f996a0f79efadd9511c94408dca...
Committer Xuesu Li
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

@resessh resessh force-pushed the enable-pass-tag-position branch from c94208a to f61e2f5 Compare November 28, 2024 04:22
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.00%. Comparing base (05db301) to head (65dd6c3).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1461   +/-   ##
=======================================
  Coverage   70.00%   70.00%           
=======================================
  Files           5        5           
  Lines          30       30           
  Branches        7        7           
=======================================
  Hits           21       21           
  Misses          8        8           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@resessh resessh force-pushed the enable-pass-tag-position branch from f61e2f5 to 65dd6c3 Compare November 28, 2024 06:45
@ymmooot ymmooot merged commit c15241b into ymmooot:master Nov 28, 2024
5 checks passed
@resessh resessh deleted the enable-pass-tag-position branch November 28, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymmooot ymmooot ymmooot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tagPosition parameter to define where the ld+json script is injected
2 participants
@resessh @ymmooot