Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vox Race #21275

Merged
merged 83 commits into from
Jun 18, 2024
Merged

Vox Race #21275

merged 83 commits into from
Jun 18, 2024

Conversation

13spacemen
Copy link
Contributor

@13spacemen 13spacemen commented Jan 18, 2024

Special Thanks

Falcon2346 from /vg/station for spriting a lot of Vox specific clothing, such as the artist, mining medic, clerk, rsecurity, robotics, paramedic, engineer, atmos, chief engieer uniforms; the labcoat and chem labcoat, the winterhood


VoxArt

Adds the famous Vox race (originally from Baystation, added in ~2013), and found on many servers like Shiptest or Paradise or /vg/

Vox are a race of nitrogen-breathing aliens. Originally a tight-knit species who lived aboard arkships, they now find themselves working on Nanotrasen space stations.

  • Oxygen is extremely toxic to Vox
  • you spawn with a pocket double nitrogen tank [which lasts forever on most servers, can be adjusted on yogs if refilling is better] and face mask, your emergency box has a nitrogen tank
  • can choose to spawn with a large n2 tank which runs out faster and can't go in pockets (challenge mode?)
  • they have blue blood, and can only accept their own V blood type
  • own language, Vox-pidgin, which sounds like shrieking
  • their organs are partially synthetic (lorewise) and vulnerable to EMPs
  • they can't be cloned due to a complex physiology
  • their organs, again cuz they're partially synthetic, don't decay at all
  • have a lot of species-specific clothing sprites [there is a system in the code for this, like digitigrade and monkeys]
  • have their own special "hair" [quills] and facial quills
  • body markings
  • 9 different skin tones
  • waggable tail with customizable tail markings
  • can be cooked into Kentucky Fried Vox
  • cool shriek sound
  • have their own plushie
  • 2 additional suicide lines [hey its something!]
  • custom husk icon, with blue blood, and the tail gets husked too!
  • cold resistance

Why is this good for the game?

This is a classic and well-loved race, and the original v1 Vox are only available on Baycode servers [and Daedalus Dock]

This is the FIRST TIME (apart from DD) where this epic race is on TG code

And this is the most feature complete Vox port. While the older TG ports are fine, they always forget to port clothing, don't add support for customization, or don't add the little things like the Vox plushie.

They have a unique alien shape and culture, leading to more engaging and fun RP.

They are NOT a furry race, the race was made before people started SS13 furry servers like skyrat and citadel, and there are absolutely no furry/sexual features.

Feel free to suggest features or general neat stuff to add to the race

Code-wise, need to make it modular (does it need to be?), and clean up the code a little

Pics

Screenshot 2024-01-18 024948

Screenshot 2024-02-10 014149

Screenshot 2024-02-10 013334

Screenshot 2024-02-08 191158

Screenshot 2024-01-31 184854

Screenshot 2024-01-29 181229

What about Vox Raiders?

The Vox Raiders spacesuits are in, I am kind of burnt out just by adding the race though. I definitely want to add in Vox Raiders as a subcategory of Pirates, with their special weapons like the Spike Thrower and their Skipjack ship. Maybe the Vox Armalis too? But most other servers don't have a functional Vox Raiders yet so you're not missing out (yet).

Oak's words echoed; "There's a time and place for everything, but not now!"

Changelog

🆑
add: The Head of Personnel has received job applications from the Vox Shoal
add: Check out the cool flags in the Gift Vendor!
add: Mimes FINALLY get their own hugbox!
/:cl:

Credits

Zuhayr from Bay for creating the race, /vg/ and Paradise for maintaining it, Oracle devs for porting it to TGcode first,
JuptyrKat and Kapu1178 for porting it to more recent TGcode

New Vox sprites from ParadiseSS13/Paradise#23502
Edited by me because there were a LOT of sprite errors in there, (good quality art though, just incomplete cropping)

Vox signaltech uniform done by me

Special Thanks

Falcon2346 from /vg/station for spriting a lot of Vox specific clothing, such as the artist, mining medic, clerk, rsecurity, robotics, paramedic, engineer, atmos, chief engieer uniforms; the labcoat and chem labcoat, the winterhood

@Yogbot-13 Yogbot-13 added the Feature This adds new content to the game label Jan 18, 2024
@github-actions github-actions bot added Admin This PR affects administrators Mapping Will result in a change to a map. labels Jan 18, 2024
@ynot01
Copy link
Contributor

ynot01 commented Jan 18, 2024

What license were these sprites sourced from and how will the license be complied with (if necessary)?

@13spacemen
Copy link
Contributor Author

@ynot01 these current sprites are newer polished sprites by @Alecksohs from Paradise, which is AGPL-3.0

@ynot01
Copy link
Contributor

ynot01 commented Jan 18, 2024

@ynot01 these current sprites are newer polished sprites by @Alecksohs from Paradise, which is AGPL-3.0

From Paradise README.md

image

Please source the commit and/or pull request these originated from on Paradise

@Moltijoe Moltijoe added the Awaiting - Action - HD Awaiting action from Jamie label Jan 18, 2024
@Moltijoe
Copy link
Contributor

Whats the reasoning behind a bunch of their internal organs being robotic?

@AMyriad
Copy link
Contributor

AMyriad commented Jan 18, 2024

Okay I'm a big fan of new races, and of ye enthusiasm to make this PR despite some of the eyebrows raised on the discord.
That bein said, I think they'd need a bit more to stand out, as almost every feature they have exists on another race.
Aversion to air? Forced to breathe from internals? Plasmamen.
Tail? Unique blood type? Lizards.
Colored blood? Skin tones? Almost every race.
Special language? Every race.

I'd say the most interesting thing they have going for them is the cybernetic stuff. Otherwise, They're really not that far gameplay-wise from being a lizard with augments.

I'm not familiar with how interesting/different the races are on other servers, but I'm not sure if people would find this to be an interesting addition to the roster.

@13spacemen
Copy link
Contributor Author

13spacemen commented Jan 18, 2024

@ynot01 added to OP

@Moltijoe the lore on servers is different, but something that they all have in common is that Vox are semi-synthetic and are somewhat "created" by a more intelligent species based on the DNA of an ancient race

This code is somewhat from Oracle, which based their Vox on Paradise's one. On Para when you get EMPed as Vox you get stunned for a while, your movement gets screwed up like Ling Res Shriek, and other effects

@AMyriad they used to have low pressure resistance, and a little tackle ability on Bay/Paradise before it was removed due to balance concerns
And I think there are a couple of things on other servers that make them unique, like on Aurora you can choose to have a sprite with 3 eyes, on Shiptest their attacks hurt more (sharp claws) and they are allergic to some common medicines
Also they cannot be cloned at all

This is still very much WIP. I'd like to get the barebones species/clothing/etc. sprites all in first and I don't mind adding any unique stuff from other servers or people's ideas

@azzzertyy
Copy link
Contributor

final commit name = pr name. you dont have to care about any other commit names

@Moltijoe
Copy link
Contributor

@Moltijoe the lore on servers is different, but something that they all have in common is that Vox are semi-synthetic and are somewhat "created" by a more intelligent species based on the DNA of an ancient race

ah, so basically preterni

@neeshacark
Copy link
Contributor

@GenericDM look its your favorite race

@Therandomhoboo
Copy link
Contributor

why bird people.... we have fly-people & mothpeople.

@YashinHak
Copy link
Contributor

an entirely new race to write lore for? delightful

@MajManatee
Copy link
Contributor

I cannot condone adding these monstrosities when foxgirls (far better) weren't added.

@Cartlord
Copy link
Contributor

Cartlord commented Jan 20, 2024

Honestly, I think these guys might make a good donator species.

@Moltijoe
Copy link
Contributor

Honestly, I think these guys might make a good donator species.

Donator species cant have unique mechanics that could potentially be seen as an upside

@cowbot92
Copy link
Contributor

ok fine they're growing on me

@MajManatee
Copy link
Contributor

MajManatee commented Jan 23, 2024

Nothing unique about them, its all just repurposed stuff from other races, even the lore.
We already have unplayed races. While I don't see an issue with more diversity, having it for the sake of having it is nonsense.
They are also ugly as hell, but that's neither here nor there.
We had a more finished, higher quality, and more wanted race that was denied for some reason before. We've also had a much cooler unique race tossed around for a while that I would much rather see (fish people)

They have a unique alien shape and culture, leading to more engaging and fun RP.

good one. Low hanging fruit, wont bother.

On Para when you get EMPed as Vox you get stunned for a while, your movement gets screwed up like Ling Res Shriek, and other effects

Confusion as a downside is incredibly minimal, but at least its something I guess.

They are NOT a furry race, the race was made before people started SS13 furry servers like skyrat and citadel, and there are absolutely no furry/sexual features.

yeah they are lol. Good try though.

Unique =/= good. snowflake stuff is usually really annoying to work with. In its current state it looks like we are going to have to re-sprite at least every form of shoe they can wear, and probably a lot of uniforms and hats too. That alone is one of my biggest concerns. Plus it makes it harder for new stuff to be made given same.

@13spacemen
Copy link
Contributor Author

13spacemen commented Jan 24, 2024

@MajManatee Already said this in discord but just putting it here too for the record

vox already has more than hundreds of sprites from all baycode servers
and you dont need special shoe sprites thats optional, the vox feet don't clip through regular shoes

they are not repurposed from other races, the vox race was made in 2013 before most other races even existed

its a very very popular race on paradise, /vg/, urist, aurora, so saying it will be unplayed is just assuming, because i guarantee you it will be played. some dude in this discord already said he cant wait to play it

the vox culture is not low hanging fruit, people DO RP about the culture and lore. people mention the IC vox lore like the skipjack and shoal all the time on pretty much every server they're on

and yes they are not a furry race. if vox are furry then are fishpeople furry? are lizards furry? are polysmorph furry? is anything that isnt synthetic or a modified human furry?

and for your sprite concerns again
paradise and /vg/ spriters have already made sprites for everything. even modsuits which are quite new, have vox sprites

you dont have to sprite something specifically for vox. you can just restrict them from wearing it in the code if you don't feel like spriting something. its no big deal its something that you have to accept if you play a uniquely shaped race

@ToasterBiome
Copy link
Contributor

Hi, this was personally approved by me that we'd at least give him the time of day to test this on yogs.

For all intents and purposes, barring lack of work or obvious programming issues this is going to be at least testmerged. Criticizing his idea or squandering his ability isn't going to get it closer to that goal, and is thus unneeded.

@Therandomhoboo
Copy link
Contributor

Hi, this was personally approved by me that we'd at least give him the time of day to test this on yogs.

For all intents and purposes, barring lack of work or obvious programming issues this is going to be at least testmerged. Criticizing his idea or squandering his ability isn't going to get it closer to that goal, and is thus unneeded.

honestly im just bored of animal x human. Be nice to have a different kind of race but w/e 3rd race with wings lets go

@ToasterBiome
Copy link
Contributor

Hi, this was personally approved by me that we'd at least give him the time of day to test this on yogs.
For all intents and purposes, barring lack of work or obvious programming issues this is going to be at least testmerged. Criticizing his idea or squandering his ability isn't going to get it closer to that goal, and is thus unneeded.

honestly im just bored of animal x human. Be nice to have a different kind of race but w/e 3rd race with wings lets go

It's surprisingly hard to think of any interesting races.

@Therandomhoboo
Copy link
Contributor

Hi, this was personally approved by me that we'd at least give him the time of day to test this on yogs.
For all intents and purposes, barring lack of work or obvious programming issues this is going to be at least testmerged. Criticizing his idea or squandering his ability isn't going to get it closer to that goal, and is thus unneeded.

honestly im just bored of animal x human. Be nice to have a different kind of race but w/e 3rd race with wings lets go

It's surprisingly hard to think of any interesting races.

I guess it also seems silly to do considering the current races are still getting patches to tweak their balance. We also had jelly race which was cool but was left to rot cause fuk that. Just saying a third race with wings isnt really that great. Rather we have golem race cause at least its minerals x humanoid.

@13spacemen 13spacemen marked this pull request as ready for review January 30, 2024 07:36
@13spacemen 13spacemen requested a review from a team as a code owner January 30, 2024 07:36
…t, robo satchel back sprite, renamed some icon states
mesonhealth by me

maint loot, vox lang tweaks, limbgrower vox fixes, species box null list fix, undergarments species sprite fix
…sprites based on id instead of name, human footprint sprite considers species_id of legs, update_icons.dm more based on specific bodyparts
…medic, robotics, chief engineer | vox sprites by falcon2346
brig phys labcoat and mining medic labcoat by me
…missing vox hardsuits and new TG vox biosuits by paradise and me
Copy link
Contributor

@SapphicOverload SapphicOverload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but there's one thing that bothers me a little.

@@ -52,6 +52,7 @@
var/skin_tone = ""
var/body_gender = ""
var/species_id = ""
var/is_husked = FALSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add another variable for this when we have TRAIT_HUSK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reason for this was TG parity, in their current implementation, body parts have this var/is_husked and most husk rendering logic works off that

aux.color = "[draw_color]"
draw_color = mutation_color || species_color || (skin_tone && skintone2hex(skin_tone))

if(is_husked)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not check if the limb's owner is husked directly instead of needing a new variable for it? You can't de-husk individual limbs anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the reason for this was so that surgically removed/gibbed husk limbs retain the husk coloration

Copy link
Contributor

@SapphicOverload SapphicOverload Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the reason for this was so that surgically removed/gibbed husk limbs retain the husk coloration

Attaching it to any other body will revert it back to normal anyway, retaining the husk coloration after dismemberment would imply that it doesn't which would be confusing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only worthwhile if we port tg's bodyparty and organ refactor
and as of yet i don't see a benefit

Yogbot-13 added a commit that referenced this pull request Jun 17, 2024
Yogbot-13 added a commit that referenced this pull request Jun 18, 2024
more checks before doing husk coloration
added dark pixels (rgb edge + #080808) to vox eye sockets to prevent transparency weirdness such as seeing turfs through head sprite
commented some vars and procs, removed redundant parts_to_husk list
@Moltijoe Moltijoe merged commit 73ce93f into yogstation13:master Jun 18, 2024
22 checks passed
Yogbot-13 added a commit that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin This PR affects administrators Awaiting - Action - HD Awaiting action from Jamie Feature This adds new content to the game Test Merge - Requested This PR is waiting for a test merge to be scheduled Test Merge - Scheduled This PR is waiting to be test merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.