Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDB IGNORE] The Great Enswitchening #21854

Merged
merged 8 commits into from
Apr 21, 2024
Merged

Conversation

Aquizit
Copy link
Contributor

@Aquizit Aquizit commented Apr 10, 2024

Document the changes in your pull request

Adds a metric shit ton of light switches to every station map and most station ruin maps.

Why is this good for the game?

While yes anyone can turn on their department lights via APC, there's something satisfying about the click of a light switch. Plus it's just a bit more flavor to things.

I tried to have a switch near a point of entry. Some rooms got more than one if they are big enough. I also adjusted a few of them if I felt I could space them better in a room.

Testing

Box comms
image

Box engine room
image

Meta AI Core
image

Meta AI Upload
image

Gax Medbay Treatment
image

Gax Morgue
image

Asteroid Cargo Sec Post
image

Asteroid Delivery Room
image

Donut Library
image

Donut Mech Bay
image

Wiki Documentation

Uh, maybe update the map images?

Changelog

🆑
mapping: You get a light switch!
mapping: YOU get a light switch!!
mapping: We ALL get light switches!
experimental: Please report if I've missed anything.
/:cl:

@Aquizit Aquizit requested a review from a team as a code owner April 10, 2024 20:35
@github-actions github-actions bot added the Mapping Will result in a change to a map. label Apr 10, 2024
@Aquizit Aquizit added the Test Merge - Requested This PR is waiting for a test merge to be scheduled label Apr 11, 2024
Yogbot-13 added a commit that referenced this pull request Apr 11, 2024
@Aquizit Aquizit added TESTMERGED This PR is currently live in a test merge. and removed Test Merge - Requested This PR is waiting for a test merge to be scheduled labels Apr 11, 2024
Yogbot-13 added a commit that referenced this pull request Apr 13, 2024
Yogbot-13 added a commit that referenced this pull request Apr 14, 2024
Yogbot-13 added a commit that referenced this pull request Apr 16, 2024
Yogbot-13 added a commit that referenced this pull request Apr 16, 2024
Yogbot-13 added a commit that referenced this pull request Apr 16, 2024
Yogbot-13 added a commit that referenced this pull request Apr 17, 2024
Yogbot-13 added a commit that referenced this pull request Apr 17, 2024
Yogbot-13 added a commit that referenced this pull request Apr 17, 2024
Yogbot-13 added a commit that referenced this pull request Apr 18, 2024
Yogbot-13 added a commit that referenced this pull request Apr 18, 2024
Yogbot-13 added a commit that referenced this pull request Apr 18, 2024
Yogbot-13 added a commit that referenced this pull request Apr 18, 2024
Yogbot-13 added a commit that referenced this pull request Apr 19, 2024
Yogbot-13 added a commit that referenced this pull request Apr 20, 2024
Yogbot-13 added a commit that referenced this pull request Apr 21, 2024
Copy link
Contributor

@AMyriad AMyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see feedback on discord in #mapping

Copy link
Contributor

@AMyriad AMyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work

@AMyriad AMyriad merged commit 049263d into yogstation13:master Apr 21, 2024
13 checks passed
Yogbot-13 added a commit that referenced this pull request Apr 21, 2024
@Aquizit Aquizit deleted the switches branch April 21, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Will result in a change to a map. TESTMERGED This PR is currently live in a test merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants