Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds OpenDream linting #21922

Merged
merged 5 commits into from
May 8, 2024
Merged

Conversation

JohnFulpWillard
Copy link
Contributor

@JohnFulpWillard JohnFulpWillard commented Apr 22, 2024

Document the changes in your pull request

Ports tgstation/tgstation#81830
Ports tgstation/tgstation#81892

Adds Opendream linting which is pretty good because it can do things that BYOND can't, and good futureproofing too.
Fixes errors that popped up w/ this as well.

I also replaced TRAVISBUILDING with CIBUILDING because with TG ports and all, they ended up being used interchangebly and meant that they both weren't being used properly.

Thanks to Altoids1 for their previous attempts throughout the years to compile Yog on OpenDream and fixing most of the errors that it threw, so I didn't really have to do much.

Changelog

Nothing player-facing.

@JohnFulpWillard JohnFulpWillard requested a review from a team as a code owner April 22, 2024 15:22
@github-actions github-actions bot added the Github changes to the .github folder label Apr 22, 2024
@ToasterBiome ToasterBiome merged commit ca1ed86 into yogstation13:master May 8, 2024
14 checks passed
@Yogbot-13 Yogbot-13 added the DME Edit This PR affects the yogstation.DME file label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DME Edit This PR affects the yogstation.DME file Github changes to the .github folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants