Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces book of babel tendril loot with ominous mirror #21936

Merged
merged 9 commits into from
May 5, 2024

Conversation

LazennG
Copy link
Contributor

@LazennG LazennG commented Apr 24, 2024

Document the changes in your pull request

adds ominous mirror to the game, a new item that summons a ghost role helper akin to holoparasites.
-can move around within 20 spaces of the mirror
-has 20 hp, does 14 brute melee damage to nonfauna enemies, which take 50.
-can fire a projectile every couple seconds that does 5 damage to nonfauna and 20 to fauna
-can swap positions with whoever is holding the mirror every 15 seconds
-can mine basalt that it walks into similar to concussive gauntlets

-Upon 'dying,' the reflection is locked in the mirror for 20 seconds where they slowly heal
-When the user isn't conscious, the reflection can't leave the mirror
-the reflection can't pull living things
-the reflection can't manifest itself outside the mirror if it's not being held

The mirror holder can:
-call the reflection back to the mirror
-swap the reflection out for a different ghost for circumstances similar to where you'd do the same for a holopara

Why is this good for the game?

book of babel sucks and i dont like a lot of ghost roles being unable to do anything without being an antag so i think this is nice.

Testing

the entering/exiting of the mirror and the swap
dreamseeker_O7KokzW6GM

being banished back to the mirror after 'dying'
dreamseeker_PIu3rEJuL7

Spriting

mirrorcrack
mirrorcrackedreal

Wiki Documentation

https://wiki.yogstation.net/wiki/Shaft_Miner#Necropolis_Chest_Loot
replace book of babel section with:
A mirror that summons a fragile companion that can assist in mining and fighting, as well as swap locations with the holder. When defeated, they're returned back to the mirror for 20 seconds, and they can't exit the mirror while the holder is unconscious or when the mirror isn't held.

Changelog

🆑 @thegoldencat413 @Chubbygummibear @LazennG
rscadd: Added ominous mirror
rscdel: Removed book of babel from tendril loot pool
imageadd: added ominous mirror sprites
/:cl:
thanks goldencat for spriting this and helping me develop it a freaking year ago

@LazennG LazennG requested a review from a team as a code owner April 24, 2024 22:07
@Yogbot-13 Yogbot-13 added DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Revert / Deletion Altoids is probably mad about this Sprites This PR has spriting changes labels Apr 24, 2024
Copy link
Contributor

@Mqiib Mqiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like spooky mirror sprite

@GDRdev
Copy link

GDRdev commented Apr 24, 2024

you know- this seems... kinda op? sorta like a budget jaunt holo

@LazennG
Copy link
Contributor Author

LazennG commented Apr 25, 2024

new changes:
-the mirror buddy is no longer dense
-bullets pass through and do 1/4th of the damage to the buddy

@thegoldencat413
Copy link
Contributor

why do the sprites suck? is the spriter stupid

@cowbot92
Copy link
Contributor

im looking for the man in the mirror

@Chubbygummibear
Copy link
Contributor

the maid in the mirror

@LazennG LazennG requested a review from Moltijoe April 27, 2024 04:06
@LazennG LazennG requested a review from Moltijoe April 27, 2024 05:52
Comment on lines +152 to +154
var/datum/action/innate/jumpback/jumpback
var/datum/action/innate/appear/appear
var/datum/action/innate/swap/swap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to delete these when the mob is destroyed

@LazennG LazennG requested a review from Moltijoe April 30, 2024 08:28
Comment on lines 56 to 58
reflected.jumpback.Remove(reflected)
reflected.appear.Remove(reflected)
reflected.swap.Remove(reflected)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put these instead on the destroy proc of the mob itself
and make sure to qdel them after removing

@LazennG LazennG requested a review from Moltijoe May 4, 2024 02:27
@Moltijoe Moltijoe merged commit c9c3a5e into yogstation13:master May 5, 2024
13 checks passed
Yogbot-13 added a commit that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Revert / Deletion Altoids is probably mad about this Sprites This PR has spriting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants