Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes random item rotation look less bad #21968

Merged
merged 1 commit into from
May 13, 2024

Conversation

SapphicOverload
Copy link
Contributor

Document the changes in your pull request

This makes randomized item rotation round to the nearest multiple of 90 degrees.

Why is this good for the game?

Rotating sprites to any degree that isn't a multiple of 90 looks bad unless the resolution is high enough, which is not the case in this game. Locking item rotation to multiples of 90 allows random rotation to still exist without making certain sprites unrecognizable or difficult to click on.

Testing

image

🆑

tweak: Randomized item rotation rounds to 90 degrees
/:cl:

@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Apr 29, 2024
@ToasterBiome
Copy link
Contributor

@LazennG state thy reason

@AMyriad
Copy link
Contributor

AMyriad commented Apr 29, 2024

can't put my finger on why but it looks a tad bizarre
I'd have to see how it does in-game to get an actual opinion

@LazennG
Copy link
Contributor

LazennG commented Apr 29, 2024

i'm not a fan because i don't like how neat it is. when item rotations were introduced i liked how it made things look strewn about and placed without any care and this feels too neat in comparison.

@Moltijoe
Copy link
Contributor

maybe try including 45 degrees too

@ToasterBiome ToasterBiome merged commit 71cf92c into yogstation13:master May 13, 2024
13 checks passed
Yogbot-13 added a commit that referenced this pull request May 13, 2024
@SapphicOverload SapphicOverload deleted the rotation-rounding branch June 20, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants