Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update singularity.dm #21996

Merged
merged 1 commit into from
May 4, 2024
Merged

Update singularity.dm #21996

merged 1 commit into from
May 4, 2024

Conversation

alexkar598
Copy link
Member

@alexkar598 alexkar598 commented May 3, 2024

About The Pull Request

Stage 2 singularities have the wrong step size, allowing them to eat the containment field if they happen to be right next to it. (For instance, if they are contained in a 3x3 or 4x4 field) 2 lines of code, and that's fixed.

Why It's Good For The Game

BEFORE
2024-05-01.15-11-12-1.mp4

AFTER
2024-05-01.15-54-45-1.mp4

The Source

This was introduced in a googlecode commit in 2011:

https://github.com/tgstation/tgstation/blob/337be2c3bcc7a739ffc927ccce9d6aa2b43c114c/code/modules/power/singularity/singularity.dm#L269

No, mport2004, I don't think this is right.

Changelog

🆑 fix: Stage 2 singularities should no longer escape containment /:cl:

tgstation/tgstation#83005
🆑 Ikalpo
fix: Stage 2 singularities should no longer escape containment
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label May 3, 2024
Copy link
Contributor

@Moltijoe Moltijoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was, in fact, not right

@Moltijoe Moltijoe added the Awaiting - Merge This PR is ready for merge label May 4, 2024
@Moltijoe Moltijoe merged commit 9ac989f into master May 4, 2024
13 checks passed
@Moltijoe Moltijoe deleted the alexkar598-patch-2 branch May 4, 2024 21:21
Yogbot-13 added a commit that referenced this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Merge This PR is ready for merge Fix This fixes an issue. Please link issues in fix PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants