Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] UPDATES DISPOSAL PATHING AND TECH #22199

Closed
wants to merge 6 commits into from

Conversation

wonderinghost
Copy link
Contributor

@wonderinghost wonderinghost commented Jun 14, 2024

Document the changes in your pull request

#21983 but for meta.
replaces all premade sort pipes with helpers
closes loops in the system and cleans up some wonky pathing
gives departments their destination tagged bins

Why is this good for the game?

because no one was going to do it otherwise. look at the bug reports, make the bug reports, don't squat on bugs. and try other maps other than box

signed,
asshole

Testing

coming back to this after i make a new image and load in

Changelog

🆑

bugfix: it is now possible to mail to dormitories and the janitors closet
mapping: reroutes meta layout

/:cl:

@wonderinghost wonderinghost requested a review from a team as a code owner June 14, 2024 07:53
@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Jun 14, 2024
@github-actions github-actions bot added the Mapping Will result in a change to a map. label Jun 14, 2024
@wonderinghost
Copy link
Contributor Author

encountered a hiccup with it not going into recycle room

@wonderinghost
Copy link
Contributor Author

doesnt actually goto the disposal room on box either. do not merge. need to figure out what is happening

@AMyriad AMyriad added the Awaiting - Action - Author This PR is awaiting an action from the author label Jun 14, 2024
@wonderinghost
Copy link
Contributor Author

figured out the problem. something in the wiring for sorting pipes is breaking the system

@wonderinghost
Copy link
Contributor Author

doesnt look to be wires

@wonderinghost
Copy link
Contributor Author

#22202 fixed the issue so now it enters disposal room. rest is set and good

@Firewolf34
Copy link
Contributor

The hero the non-box-maps deserve (and needed)

@AMyriad AMyriad removed the Awaiting - Action - Author This PR is awaiting an action from the author label Jun 27, 2024
@wonderinghost
Copy link
Contributor Author

i love having to update branch and it deletes my commits

@wonderinghost wonderinghost reopened this Jul 7, 2024
@Moltijoe
Copy link
Contributor

reopen this when you come back

@Moltijoe Moltijoe closed this Jul 11, 2024
@wonderinghost
Copy link
Contributor Author

review libo'd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix This fixes an issue. Please link issues in fix PRs Mapping Will result in a change to a map.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants