Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes backstories sometimes crashing if you're hijack or martyr bound #22658

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixes backstories sometimes crashing if you're hijack or martyr bound #22658

wants to merge 3 commits into from

Conversation

cowbot92
Copy link
Contributor

Document the changes in your pull request

fixes this

Testing

removing returns is how to fix this

Changelog

🆑
bugfix: Fixed bacjstorises crashing

/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Sep 27, 2024
ToasterBiome
ToasterBiome requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could probably just setup the backstories right before each return

@cowbot92
Copy link
Contributor Author

cowbot92 commented Oct 8, 2024

you could probably just setup the backstories right before each return

done @ToasterBiome

ToasterBiome
ToasterBiome requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure you need to pass some args into those procs

@ynot01 ynot01 added the Awaiting - Action - Author This PR is awaiting an action from the author label Oct 11, 2024
@cowbot92
Copy link
Contributor Author

pretty sure you need to pass some args into those procs

dont be a baby the proc can figure it out itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToasterBiome ToasterBiome ToasterBiome requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Awaiting - Action - Author This PR is awaiting an action from the author Fix This fixes an issue. Please link issues in fix PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cowbot92 @ToasterBiome @ynot01 @Yogbot-13