-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pAI Redux #22751
Open
Oblisk234
wants to merge
44
commits into
yogstation13:master
Choose a base branch
from
Oblisk234:modularpda-fixpais
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
pAI Redux #22751
+972
−755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yogbot-13
added
Feature
This adds new content to the game
Fix
This fixes an issue. Please link issues in fix PRs
Revert / Deletion
Altoids is probably mad about this
Tweak
This PR contains changes to the game.
labels
Oct 20, 2024
Based TGUI PR |
AMyriad
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just path changes, map is gut
fucking F I N A L L Y 'while it may work' NUH UH. a lot of shit is broken with the html ui. you have saved me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
This adds new content to the game
Fix
This fixes an issue. Please link issues in fix PRs
Mapping
Will result in a change to a map.
Revert / Deletion
Altoids is probably mad about this
Tweak
This PR contains changes to the game.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22094
Document the changes in your pull request
Makes the pAI card insertable into PDAs again, as well as adding an updated interface for pAIs. Also fixes an issue with ghosts not being notified of pAI requests.
Enables usage of the Sunglasses image display, which seems to not have been available at all and left in the code.
For now, disables security and medical records modules as I can't figure out how to implement them currently.
Changes a lot of the underlying pAI code since it relied mostly on the HTML UI.
Why is this good for the game?
While it may work, the original HTML panel is very crappy, and over 10 years old at this point. pAIs would benefit from a new UI that looks a lot better and is more functional.
Putting pAIs into PDAs kind of got phased out after modular PDAs became the standard and wasn't made compatible, and the feature was limited to old PDAs, which were removed recently. This PR reintroduces that feature, unless we switch to another different PDA system down the line and this happens again.
Testing
pAI in PDA:
Directives tab:
Software download tab:
pAI card:
Probably will need to record a video for the rest of the modules that have tabs.
Wiki Documentation
Pretty sure this PR makes that one tip in Guide to Awesome Miscellaneous Stuff about inserting pAIs into PDAs accurate again.
Changelog
🆑
rscadd: pAIs now have a new interface to use.
rscdel: Removed old pAI interface
bugfix: Fixed pAI door jacking not auto-canceling after hacking completes
tweak: pAI cards have had their connectors changed, and can now fit in modular PDAs!
/:cl: