Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pAI Redux #22751

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

pAI Redux #22751

wants to merge 44 commits into from

Conversation

Oblisk234
Copy link
Contributor

@Oblisk234 Oblisk234 commented Oct 20, 2024

Fixes #22094

Document the changes in your pull request

Makes the pAI card insertable into PDAs again, as well as adding an updated interface for pAIs. Also fixes an issue with ghosts not being notified of pAI requests.

Enables usage of the Sunglasses image display, which seems to not have been available at all and left in the code.
image

For now, disables security and medical records modules as I can't figure out how to implement them currently.

Changes a lot of the underlying pAI code since it relied mostly on the HTML UI.

Why is this good for the game?

While it may work, the original HTML panel is very crappy, and over 10 years old at this point. pAIs would benefit from a new UI that looks a lot better and is more functional.

Putting pAIs into PDAs kind of got phased out after modular PDAs became the standard and wasn't made compatible, and the feature was limited to old PDAs, which were removed recently. This PR reintroduces that feature, unless we switch to another different PDA system down the line and this happens again.

Testing

pAI in PDA:
image

Directives tab:
image

Software download tab:
image
image

pAI card:
image
image
image
image

Probably will need to record a video for the rest of the modules that have tabs.

Wiki Documentation

Pretty sure this PR makes that one tip in Guide to Awesome Miscellaneous Stuff about inserting pAIs into PDAs accurate again.

Changelog

🆑
rscadd: pAIs now have a new interface to use.
rscdel: Removed old pAI interface
bugfix: Fixed pAI door jacking not auto-canceling after hacking completes
tweak: pAI cards have had their connectors changed, and can now fit in modular PDAs!
/:cl:

@Oblisk234 Oblisk234 requested a review from a team as a code owner October 20, 2024 20:58
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Revert / Deletion Altoids is probably mad about this Tweak This PR contains changes to the game. labels Oct 20, 2024
@github-actions github-actions bot added the Mapping Will result in a change to a map. label Oct 20, 2024
@Scrambledeggs00
Copy link
Contributor

Based TGUI PR

Copy link
Contributor

@AMyriad AMyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just path changes, map is gut

@neeshacark
Copy link
Contributor

fucking F I N A L L Y

'while it may work'

NUH UH. a lot of shit is broken with the html ui. you have saved me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pAI door jacking doesn't reset after door is opened
5 participants