Add binary space partition and random room placement algorithms for procedural generation #3

Chubbygummibear · 2023-10-02T20:52:44Z

I hope I'm doing this right. This is the code I've been testing with and it compiles using the default
cargo build --release --target i686-pc-windows-msvc
from the readme so I assume that means it will work and won't destroy the server

Adds rust functions for binary space partitioning and random room placement. Currently just for my procedural maintenance generation code, but can be applied to more than that in the future, should anyone else want to use it

Binary Space Partitioning:

In computer science, binary space partitioning (BSP) is a method for space partitioning which recursively subdivides a Euclidean space into two convex sets by using hyperplanes as partitions. This process of subdividing gives rise to a representation of objects within the space in the form of a tree data structure known as a BSP tree.

Basically cutting a shape in half, then that half in half, recursively until all subsections are equal to a minimum given size, or further cuts would reduce the size beneath the desired minimum

Random Room Placement:

Given an area of specified dimensions, will create rooms of varying dimensions and place them randomly in the area. The only logic applied is that the rooms fit within the boundaries of the area and don't overlap one another

Credit to https://www.jamesbaum.co.uk/blether/procedural-level-generation-rust/ for getting me started with the code I needed to make this work

AshCorr · 2023-10-05T11:06:38Z

src/binary_space_partition.rs

+    if map_subsection_min_size < map_subsection_min_room_width || map_subsection_min_size < map_subsection_min_room_height{
+        map_subsection_min_size = cmp::max(map_subsection_min_room_width, map_subsection_min_room_height) + 1
+    }


Trying to understand this logic. So if the map_subsection_min_size is less than map_subsection_min_room_width or map_subsection_min_room_width it'll be set to whatever is highest + 1.

From the sounds of it it seems like you want map_subsection_min_size to always be atleast 1 more than map_subsection_min_room_width and map_subsection_min_room_height

If that is the case then I think you might have a bug, you should be using <= not < or else you could end up in the scenario of map_subsection_min_size being equal to map_subsection_min_size

and you could also simplify this to

Suggested change

if map_subsection_min_size < map_subsection_min_room_width || map_subsection_min_size < map_subsection_min_room_height{

map_subsection_min_size = cmp::max(map_subsection_min_room_width, map_subsection_min_room_height) + 1

}

let map_subsection_min_size = cmp::max(

map_subsection_min_size_as_str.parse::<i32>()?,

cmp::max(map_subsection_min_room_width, map_subsection_min_room_height) + 1

)

and avoid using a mutable variable

gotcha about the mut, and updated to use your double cmp method over the if then cmp 👍

AshCorr · 2023-10-05T11:07:54Z

src/binary_space_partition.rs

+    let mut string = String::new();
+    for room in &level.all_rooms {
+        let serialized = serde_json::to_string(&room).unwrap();
+        let _ = write!(string, "{}", serialized);
+        //println!("serialized = {}", serialized);
+    }


Is this leftover debug code? I don't see where the string value is used!

you're right my b, got rid of it

AshCorr · 2023-10-05T11:09:06Z

src/binary_space_partition.rs

+        //println!("serialized = {}", serialized);
+    }
+
+    Ok(format!("{}",serde_json::to_string(&level.all_rooms)?))


Suggested change

Ok(format!("{}",serde_json::to_string(&level.all_rooms)?))

serde_json::to_string(&level.all_rooms)

serde_json::to_string already returns a Result<String>, maybe you can just return that?

Unfortunately just trying to return the serde_json::to_string gives me
mismatched types serde_json::Error and error::Error have similar names, but are actually distinct types
but wrapping it in an Ok()? converts the error into the appropriate error rust-g is expecting

AshCorr

Mightt be worth reviewing all your commented code and either removing it or uncommenting it! Makes it a little confusing to know whats what.

AshCorr · 2023-10-12T20:52:10Z

src/random_room_placement.rs

+        let max_rooms = desired_room_count as usize;
+        let max_attempts = 15;
+        let mut attempts = 0;
+        while self.level.all_rooms.iter().filter(|&rm| rm.room_type == 3).count() <= max_rooms && attempts <= max_attempts {


rm.room_type == 3

Could we maybe use some kind of enum for room_type? hard to know what 3 is supposed to mean!

AshCorr · 2023-10-12T20:58:15Z

src/random_room_placement.rs

+    }
+
+    fn place_rooms_random(&mut self, desired_room_count: i32, rng: &mut StdRng) {
+        let max_rooms = desired_room_count as usize;


could you not make place_rooms_Random take a usize ? or just use an i32?

AshCorr · 2023-10-12T21:02:35Z

src/random_room_placement.rs

+        map.level
+    }
+
+    fn place_rooms_random(&mut self, desired_room_count: i32, rng: &mut StdRng) {


Tbh is it worth just making place_rooms_random a function of Level instead of creating an entirely different RandomRoomLevel struct?

AshCorr · 2023-10-12T21:03:04Z

src/random_room_placement.rs

+    board: Vec<Vec<i32>>,
+    all_rooms: Vec<Room>,
+    increment: i32,
+    //hash: String,


still need this?

AshCorr · 2023-10-12T21:06:11Z

src/random_room_placement.rs

+        for _ in 0..self.height {
+            let space_tile = 0;
+            //let wall_tile = 1;
+            let floor_tile = 5;


Maybe you could have a TileType enum?

AshCorr · 2023-10-12T21:07:26Z

src/random_room_placement.rs

+            let gen_floor_first = true;
+
+            let mut row = vec![floor_tile; self.width as usize];
+            if !gen_floor_first {
+                row = vec![space_tile; self.width as usize];
+            }
+            // if gen_floor_first {
+            //     if index == 0 || index == self.height - 1 {
+            //         row = vec![wall_tile; self.width as usize];
+            //     }
+
+            //     row[0] = wall_tile;
+            //     row[self.width as usize - 1] = wall_tile;
+            // }


Looks like you meant to do something with gen_floor_first here?

AshCorr · 2023-10-12T21:14:33Z

src/random_room_placement.rs

+        let height: i32;
+        match *self {
+            RoomDimensions::Maint3x3 => height = 3,
+            RoomDimensions::Maint3x5 => height = 5,
+            RoomDimensions::Maint5x3 => height = 3,
+            RoomDimensions::Maint5x4 => height = 4,
+            RoomDimensions::Maint10x5 => height = 5,
+            RoomDimensions::Maint10x10 => height = 10,
+        }
+        return height + 2


Suggested change

let height: i32;

match *self {

RoomDimensions::Maint3x3 => height = 3,

RoomDimensions::Maint3x5 => height = 5,

RoomDimensions::Maint5x3 => height = 3,

RoomDimensions::Maint5x4 => height = 4,

RoomDimensions::Maint10x5 => height = 5,

RoomDimensions::Maint10x10 => height = 10,

}

return height + 2

match *self {

RoomDimensions::Maint3x3 => 3,

RoomDimensions::Maint3x5 => 5,

RoomDimensions::Maint5x3 => 3,

RoomDimensions::Maint5x4 => 4,

RoomDimensions::Maint10x5 => 5,

RoomDimensions::Maint10x10 => 10,

} + 2

AshCorr · 2023-10-12T21:15:21Z

src/random_room_placement.rs

+        let width: i32;
+        match *self {
+            RoomDimensions::Maint3x3 => width = 3,
+            RoomDimensions::Maint3x5 => width = 3,
+            RoomDimensions::Maint5x3 => width = 5,
+            RoomDimensions::Maint5x4 => width = 5,
+            RoomDimensions::Maint10x5 => width = 10,
+            RoomDimensions::Maint10x10 => width = 10,
+        }
+        return width + 2;


Suggested change

let width: i32;

match *self {

RoomDimensions::Maint3x3 => width = 3,

RoomDimensions::Maint3x5 => width = 3,

RoomDimensions::Maint5x3 => width = 5,

RoomDimensions::Maint5x4 => width = 5,

RoomDimensions::Maint10x5 => width = 10,

RoomDimensions::Maint10x10 => width = 10,

}

return width + 2;

match *self {

RoomDimensions::Maint3x3 => width = 3,

RoomDimensions::Maint3x5 => width = 3,

RoomDimensions::Maint5x3 => width = 5,

RoomDimensions::Maint5x4 => width = 5,

RoomDimensions::Maint10x5 => width = 10,

RoomDimensions::Maint10x10 => width = 10,

} + 2

Might also want a comment for what the + 2 is for!

src/binary_space_partition.rs

simplify is_leaf Co-authored-by: Ashleigh Carr <[email protected]>

Chubbygummibear added 2 commits October 2, 2023 13:44

procgen stuff

2dd9e5c

alphabetize me captn

90f4bbc

AshCorr reviewed Oct 5, 2023

View reviewed changes

Chubbygummibear added 2 commits October 5, 2023 14:48

remove debug lines, remove unnecessary format proc, add procs to readme

d5dbf62

probably better compare logic

07ee378

Chubbygummibear requested a review from AshCorr October 5, 2023 22:35

AshCorr reviewed Oct 12, 2023

View reviewed changes

Chubbygummibear added 2 commits October 13, 2023 15:16

random room placement cleanup

ec5d448

more cleanup

16917f1

AshCorr approved these changes Nov 3, 2023

View reviewed changes

src/binary_space_partition.rs Outdated Show resolved Hide resolved

src/binary_space_partition.rs Show resolved Hide resolved

Update src/binary_space_partition.rs

d583aba

simplify is_leaf Co-authored-by: Ashleigh Carr <[email protected]>

ToasterBiome merged commit fa6e3bc into yogstation13:master Nov 4, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add binary space partition and random room placement algorithms for procedural generation #3

Add binary space partition and random room placement algorithms for procedural generation #3

Chubbygummibear commented Oct 2, 2023 •

edited

Loading

AshCorr Oct 5, 2023

Chubbygummibear Oct 5, 2023

AshCorr Oct 5, 2023

Chubbygummibear Oct 5, 2023

AshCorr Oct 5, 2023 •

edited

Loading

Chubbygummibear Oct 5, 2023

AshCorr left a comment

AshCorr Oct 12, 2023

AshCorr Oct 12, 2023

AshCorr Oct 12, 2023

AshCorr Oct 12, 2023

AshCorr Oct 12, 2023

AshCorr Oct 12, 2023

AshCorr Oct 12, 2023 •

edited

Loading

AshCorr Oct 12, 2023

AshCorr Oct 12, 2023

	Ok(format!("{}",serde_json::to_string(&level.all_rooms)?))
	serde_json::to_string(&level.all_rooms)

Add binary space partition and random room placement algorithms for procedural generation #3

Add binary space partition and random room placement algorithms for procedural generation #3

Conversation

Chubbygummibear commented Oct 2, 2023 • edited Loading

Binary Space Partitioning:

Random Room Placement:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AshCorr Oct 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AshCorr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AshCorr Oct 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chubbygummibear commented Oct 2, 2023 •

edited

Loading

AshCorr Oct 5, 2023 •

edited

Loading

AshCorr Oct 12, 2023 •

edited

Loading