Improve logging #245
Merged
Improve logging #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 25, 2023 11:45
Added tools.cli as dependency, configured logger
Signed-off-by: Andrei <sandre1>
ieugen
reviewed
Jul 25, 2023
|
Overall looks good, I think the only change I'd do would be to default to info when no log level is set. |
|
Also part of improve logging (sort of :) ) i've dealt with the error in case of no config file provided. |
yogthos
approved these changes
Jul 26, 2023
|
I think I'm good to merge this in unless there's anything else you were thinking of adding. |
|
For now, is ok to merge. Thank you. |
|
sounds like a plan, and let me know when you think is a good time for a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress on migratus #240
[1] I have implemented a --verbose CLI option to set the log level.