Set scanOnPenHover to false by default (#1853)

yomidevs · Mar 4, 2025 · 3ac9238 · 3ac9238
1 parent 1467dde
commit 3ac9238
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/ext/data/schemas/options-schema.json b/ext/data/schemas/options-schema.json
@@ -505,7 +505,7 @@
                                                     "scanOnTouchPress": false,
                                                     "scanOnTouchRelease": false,
                                                     "scanOnPenMove": true,
-                                                    "scanOnPenHover": true,
+                                                    "scanOnPenHover": false,
                                                     "scanOnPenReleaseHover": false,
                                                     "scanOnPenPress": true,
                                                     "scanOnPenRelease": false,
@@ -531,7 +531,7 @@
                                                     "scanOnTouchPress": false,
                                                     "scanOnTouchRelease": false,
                                                     "scanOnPenMove": true,
-                                                    "scanOnPenHover": true,
+                                                    "scanOnPenHover": false,
                                                     "scanOnPenReleaseHover": false,
                                                     "scanOnPenPress": true,
                                                     "scanOnPenRelease": false,
@@ -634,7 +634,7 @@
                                                         },
                                                         "scanOnPenHover": {
                                                             "type": "boolean",
-                                                            "default": true
+                                                            "default": false
                                                         },
                                                         "scanOnPenReleaseHover": {
                                                             "type": "boolean",

diff --git a/ext/js/data/options-util.js b/ext/js/data/options-util.js
@@ -644,7 +644,7 @@ export class OptionsUtil {
             searchTerms: true,
             searchKanji: true,
             scanOnTouchMove: false,
-            scanOnPenHover: true,
+            scanOnPenHover: false,
             scanOnPenPress: true,
             scanOnPenRelease: false,
             preventTouchScrolling: true,

diff --git a/ext/js/pages/settings/scan-inputs-controller.js b/ext/js/pages/settings/scan-inputs-controller.js
@@ -213,7 +213,7 @@ export class ScanInputsController {
                 scanOnTouchPress: false,
                 scanOnTouchRelease: false,
                 scanOnPenMove: true,
-                scanOnPenHover: true,
+                scanOnPenHover: false,
                 scanOnPenReleaseHover: false,
                 scanOnPenPress: true,
                 scanOnPenRelease: false,

diff --git a/test/options-util.test.js b/test/options-util.test.js
@@ -385,7 +385,7 @@ function createProfileOptionsUpdatedTestData1() {
                         scanOnTouchPress: false,
                         scanOnTouchRelease: false,
                         scanOnPenMove: true,
-                        scanOnPenHover: true,
+                        scanOnPenHover: false,
                         scanOnPenReleaseHover: false,
                         scanOnPenPress: true,
                         scanOnPenRelease: false,
@@ -411,7 +411,7 @@ function createProfileOptionsUpdatedTestData1() {
                         scanOnTouchPress: false,
                         scanOnTouchRelease: false,
                         scanOnPenMove: true,
-                        scanOnPenHover: true,
+                        scanOnPenHover: false,
                         scanOnPenReleaseHover: false,
                         scanOnPenPress: true,
                         scanOnPenRelease: false,
@@ -437,7 +437,7 @@ function createProfileOptionsUpdatedTestData1() {
                         scanOnTouchPress: false,
                         scanOnTouchRelease: false,
                         scanOnPenMove: true,
-                        scanOnPenHover: true,
+                        scanOnPenHover: false,
                         scanOnPenReleaseHover: false,
                         scanOnPenPress: true,
                         scanOnPenRelease: false,