Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up playwright (pt1: preparation) #1717

Merged
merged 5 commits into from
Dec 29, 2024
Merged

Conversation

djahandarie
Copy link
Collaborator

@djahandarie djahandarie commented Dec 28, 2024

This is part 1 of a two-part change set that will greatly speed up playwright.

This PR:

  • Starts splitting up the visual tests into different tests, in preparation for parallelization
  • Switches the dictionary used for the popup test to the very trivial test dictionary so it loads super fast, which is preparation for further splitting up of the visual tests
  • Eliminates some unnecessary timeouts by tracking whether we expect the popup to actually show or not per test

The upcoming changes second PR will reap all the gains here, but the change to the screenshots will be more confusing (as the file paths will change, breaking the screenshot differ), so I've decided to split the changes into two so reviewers can see how the screenshots change without the file paths changing in this PR.

Also, I understand that the content of the popup is a little more trivial now, but that is fine, as I plan on building a proper separate set of playwright tests for very complex popups with structured content, SVGs, etc, but that will come later.

@djahandarie djahandarie requested a review from a team as a code owner December 28, 2024 14:46
Copy link

github-actions bot commented Dec 28, 2024

Copy link

codspeed-hq bot commented Dec 28, 2024

CodSpeed Performance Report

Merging #1717 will not alter performance

Comparing speed-up-playwright (c4d41b8) with master (f342886)

Summary

✅ 5 untouched benchmarks

@djahandarie djahandarie changed the title Speed up playwright Speed up playwright (pt1: preparation) Dec 28, 2024
@Kuuuube Kuuuube added the area/ci The issue or PR is related to continuous integration and/or continuous delivery label Dec 29, 2024
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 29, 2024
@djahandarie djahandarie added this pull request to the merge queue Dec 29, 2024
Merged via the queue into master with commit 715e95a Dec 29, 2024
22 checks passed
@djahandarie djahandarie deleted the speed-up-playwright branch December 29, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci The issue or PR is related to continuous integration and/or continuous delivery kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants