Speed up playwright (pt1: preparation) #1717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of a two-part change set that will greatly speed up playwright.
This PR:
The upcoming changes second PR will reap all the gains here, but the change to the screenshots will be more confusing (as the file paths will change, breaking the screenshot differ), so I've decided to split the changes into two so reviewers can see how the screenshots change without the file paths changing in this PR.
Also, I understand that the content of the popup is a little more trivial now, but that is fine, as I plan on building a proper separate set of playwright tests for very complex popups with structured content, SVGs, etc, but that will come later.