-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add norwegian #1804
add norwegian #1804
Conversation
Changes ISO 639-3 code to support fetching from Lingua Libre.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about Norwegian, what do you think are the pros and cons of having these two as separate options vs joined?
Would deinflection be the same?
Would your typical user want both nn and nb dicts?
(audio might also be affected by which iso codes lingua libre and forvo use 😴 )
I had them joined as one language initially, but then I was reading that Nynorsk can have different inflection rules, so I was worried that if someone made a language transformer, it would conflict with the other written form.
Nynorsk seems to have better definitions for the many words Bokmål and Nynorsk have in common, so that could be a good reason to merge the two. They're also both small languages on Wiktionary, so combining them would help get better coverage.
Lingua Libre requires I'm still a beginner in Norwegian myself, so I'm not sure what the best approach would be. Merging the two options into one might be the best way to go right now, and if users have issues we can split them back into two. What do you think? Should I make a commit joining the two? |
Based on that, it might be better to have them as one option with |
Merges Bokmål and Nynorsk into one language option.
Alright, made the commit. |
Adds Norwegian Bokmål and Norwegian Nynorsk.