Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add norwegian #1804

Merged
merged 3 commits into from
Feb 5, 2025
Merged

add norwegian #1804

merged 3 commits into from
Feb 5, 2025

Conversation

seth-js
Copy link

@seth-js seth-js commented Feb 5, 2025

Adds Norwegian Bokmål and Norwegian Nynorsk.

@seth-js seth-js requested a review from a team as a code owner February 5, 2025 03:13
Changes ISO 639-3 code to support fetching from Lingua Libre.
StefanVukovic99
StefanVukovic99 previously approved these changes Feb 5, 2025
Copy link
Collaborator

@StefanVukovic99 StefanVukovic99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about Norwegian, what do you think are the pros and cons of having these two as separate options vs joined?
Would deinflection be the same?
Would your typical user want both nn and nb dicts?
(audio might also be affected by which iso codes lingua libre and forvo use 😴 )

@seth-js
Copy link
Author

seth-js commented Feb 5, 2025

what do you think are the pros and cons of having these two as separate options vs joined?
Would deinflection be the same?

I had them joined as one language initially, but then I was reading that Nynorsk can have different inflection rules, so I was worried that if someone made a language transformer, it would conflict with the other written form.

Would your typical user want both nn and nb dicts?

Nynorsk seems to have better definitions for the many words Bokmål and Nynorsk have in common, so that could be a good reason to merge the two. They're also both small languages on Wiktionary, so combining them would help get better coverage.

audio might also be affected by which iso codes lingua libre and forvo use

Lingua Libre requires nor to be sent over, but Forvo requires either nn for Nynorsk or no for Bokmål. I don't know if Forvo is still supported, but that would require a change for the server to merge those two results into one.

I'm still a beginner in Norwegian myself, so I'm not sure what the best approach would be. Merging the two options into one might be the best way to go right now, and if users have issues we can split them back into two.

What do you think? Should I make a commit joining the two?

@StefanVukovic99
Copy link
Collaborator

Based on that, it might be better to have them as one option with no/nor, if it's not too much trouble. When/if someone writes deinflection we can split it.

Merges Bokmål and Nynorsk into one language option.
@seth-js
Copy link
Author

seth-js commented Feb 5, 2025

Alright, made the commit.

@StefanVukovic99 StefanVukovic99 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into yomidevs:master with commit 75824b0 Feb 5, 2025
25 checks passed
@seth-js seth-js deleted the norwegian-support branch February 7, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants