Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show dictionaries with at least one term for single-glossary handlebars #1811

Merged

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Feb 8, 2025

Some users have thought they could use the single-glossary handlebars for frequency or pronunciation dicts due to them showing on the list. This removes them. It also opens the door for other handlebars for example single-frequency or single-pitch-accent.

@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/ui-ux The issue or PR is related to UI/UX/Design labels Feb 8, 2025
@Kuuuube Kuuuube requested a review from a team as a code owner February 8, 2025 18:37
@Kuuuube Kuuuube added this pull request to the merge queue Feb 8, 2025
Merged via the queue into yomidevs:master with commit 91afaa1 Feb 8, 2025
25 checks passed
@Kuuuube Kuuuube deleted the fix-single-glossary-shown-for-non-glossary branch February 8, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants