Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cutoff indicator and audio failed X on search page #1815

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Feb 11, 2025

Fixes #1814
Fixes #1812

content-visibility: auto; appears to only render elements in padding when the padding comes from the element itself. Not any if its children. This shifts the padding from being provided by --main-content-horizontal-padding to --entry-horizontal-padding (which is applied to the entry class) on the search page.

Added --query-horizontal-padding to allow the search page to override the padding of that element as it had done before but without it breaking the rendering of everything on the sides.

(The element that has padding set to 0):
Screenshot_2025-02-11_14-46-39

Before After
before after

(There is no difference besides the triangle displaying on the left side)

@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/ui-ux The issue or PR is related to UI/UX/Design regression This issue or PR is related to a regression labels Feb 11, 2025
@Kuuuube Kuuuube requested a review from a team as a code owner February 11, 2025 19:48
Copy link
Collaborator

@StefanVukovic99 StefanVukovic99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kuuuube Kuuuube added this pull request to the merge queue Feb 21, 2025
Merged via the queue into yomidevs:master with commit 1c1d104 Feb 21, 2025
25 checks passed
@Kuuuube Kuuuube deleted the fix-cutoff-search-page branch February 21, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug regression This issue or PR is related to a regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio failed X is cut off on search page [BUG]: No Selection indicator on Yomitan Search Page
2 participants