Skip to content

Commit

Permalink
Add .nvmrc to specify Node.js version (#429)
Browse files Browse the repository at this point in the history
* chore: specify node version v18

* chore(.github/workflows): update actions/setup-node to use 'node-version-file' instead of 'node-version
  • Loading branch information
DongjaJ authored Dec 23, 2024
1 parent 2e5b55e commit ba09115
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 12 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/ci_backend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ jobs:
test:
name: Check the source code
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x]
env:
working-directory: ./backend
steps:
Expand All @@ -29,7 +26,7 @@ jobs:
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version-file: '.nvmrc'
cache: "pnpm"
- name: Install packages
run: pnpm install --frozen-lockfile
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/ci_frontend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,17 @@ jobs:
test:
name: Check the source code
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x]
env:
working-directory: ./frontend
steps:
- name: Checkout 🛎️
uses: actions/checkout@v4
- name: Install pnpm
uses: pnpm/action-setup@v4
- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version-file: '.nvmrc'
cache: "pnpm"
- name: Install packages
run: pnpm install --frozen-lockfile
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/desktop-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ jobs:
strategy:
matrix:
os: [macos-latest, ubuntu-latest, windows-latest]
node-version: [18.x]

defaults:
run:
Expand All @@ -22,7 +21,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version-file: '.nvmrc'

- name: Set up pnpm
uses: pnpm/action-setup@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gh_pages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Node 🔧
uses: actions/setup-node@v4
with:
node-version: "18"
node-version-file: '.nvmrc'
cache: "pnpm"
cache-dependency-path: pnpm-lock.yaml

Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v18

0 comments on commit ba09115

Please sign in to comment.