Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default syncLoopDuration and Expose yorkie.Document #386

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

devleejb
Copy link
Member

@devleejb devleejb commented Oct 26, 2024

What this PR does / why we need it:

  • Change default syncLoopDuration
  • Expose yorkie.Document

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • New Features

    • Introduced a configurable synchronization loop duration for improved client performance.
    • Added a debugging feature that exposes the document to the global window object.
  • Documentation

    • Updated the Window interface to include a new property for enhanced functionality.

Copy link
Contributor

coderabbitai bot commented Oct 26, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve modifications to the useYorkieDocument hook in the frontend/src/hooks/useYorkieDocument.ts file, where a new parameter syncLoopDuration is introduced for client configuration. This parameter defaults to 200 if not specified and is passed to the yorkie.Client constructor. Additionally, the newly created document is assigned to the global window.doc for debugging purposes. The frontend/src/vite-env.d.ts file is updated to include this new property in the Window interface.

Changes

File Change Summary
frontend/src/hooks/useYorkieDocument.ts Added syncLoopDuration parameter to createYorkieClient, set window.doc to new document.
frontend/src/vite-env.d.ts Updated Window interface to include doc of type CodePairDocType.

Poem

In the code where rabbits hop,
A sync loop's set to never stop.
With doc now on the window wide,
Debugging's fun, come take a ride!
A parameter new, oh what a treat,
In our code, it's quite the feat! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@devleejb devleejb merged commit 5f47edc into main Oct 26, 2024
2 checks passed
@devleejb devleejb deleted the yorkie-debug branch October 26, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant