Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DisableGC option to document #136

Merged
merged 14 commits into from
Oct 17, 2023
Merged

Add DisableGC option to document #136

merged 14 commits into from
Oct 17, 2023

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Oct 16, 2023

What this PR does / why we need it?

Add DisableGC option to document.

Any background context you want to provide?

I'll change the base branch after to_tree_node is merged.

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 added the enhancement 🌟 New feature or request label Oct 16, 2023
@7hong13 7hong13 requested review from hackerwins and skhugh October 16, 2023 10:22
@7hong13 7hong13 self-assigned this Oct 16, 2023
Base automatically changed from to_tree_node to main October 17, 2023 05:37
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 140 lines in your changes are missing coverage. Please review.

Comparison is base (5290bdb) 83.05% compared to head (85adc36) 78.22%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   83.05%   78.22%   -4.84%     
==========================================
  Files          63       63              
  Lines        3654     3678      +24     
  Branches      534      573      +39     
==========================================
- Hits         3035     2877     -158     
- Misses        325      503     +178     
- Partials      294      298       +4     
Files Coverage Δ
...rkie/src/main/kotlin/dev/yorkie/core/Attachment.kt 100.00% <100.00%> (ø)
yorkie/src/main/kotlin/dev/yorkie/core/Presence.kt 100.00% <100.00%> (ø)
...tlin/dev/yorkie/document/JsonSerializableStruct.kt 61.90% <100.00%> (+8.96%) ⬆️
...c/main/kotlin/dev/yorkie/document/change/Change.kt 72.22% <100.00%> (-27.78%) ⬇️
...c/main/kotlin/dev/yorkie/document/crdt/CrdtText.kt 88.33% <ø> (-1.38%) ⬇️
...lin/dev/yorkie/document/crdt/CrdtTreeExtensions.kt 100.00% <100.00%> (ø)
...ie/src/main/kotlin/dev/yorkie/document/crdt/Rht.kt 84.00% <100.00%> (-4.47%) ⬇️
...c/main/kotlin/dev/yorkie/document/crdt/TextInfo.kt 86.20% <100.00%> (-1.68%) ⬇️
...ain/kotlin/dev/yorkie/document/json/JsonElement.kt 76.92% <100.00%> (+1.92%) ⬆️
...main/kotlin/dev/yorkie/document/json/JsonObject.kt 92.59% <100.00%> (+1.23%) ⬆️
... and 24 more

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@7hong13 7hong13 merged commit d244681 into main Oct 17, 2023
7 checks passed
@7hong13 7hong13 deleted the gc branch October 17, 2023 11:43
@7hong13 7hong13 added this to the 0.4.7 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants