-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tree.Edit benchmark and improve performance #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
there is |
I added the omitted tests for GC using |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 78.22% 78.22%
=======================================
Files 63 63
Lines 3678 3679 +1
Branches 573 573
=======================================
+ Hits 2877 2878 +1
Misses 503 503
Partials 298 298
☔ View full report in Codecov by Sentry. |
What this PR does / why we need it?
Added benchmark tests based on the JS SDK.
(I didn't include tests related to GC since I'm unsure whether exposinggarbageCollect()
andgarbageLength
to the public only for benchmark tests is acceptable. I’ll consider the proper way to handle it.)Any background context you want to provide?
I'll change the base branch to
main
aftergc
is merged.What are the relevant tickets?
Fixes #
Checklist