Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tree.Edit benchmark and improve performance #137

Merged
merged 16 commits into from
Oct 17, 2023
Merged

Add Tree.Edit benchmark and improve performance #137

merged 16 commits into from
Oct 17, 2023

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Oct 16, 2023

What this PR does / why we need it?

Added benchmark tests based on the JS SDK.
(I didn't include tests related to GC since I'm unsure whether exposing garbageCollect() and garbageLength to the public only for benchmark tests is acceptable. I’ll consider the proper way to handle it.)

Any background context you want to provide?

I'll change the base branch to main after gc is merged.

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 added the enhancement 🌟 New feature or request label Oct 16, 2023
@7hong13 7hong13 requested review from hackerwins and skhugh October 16, 2023 10:31
@7hong13 7hong13 self-assigned this Oct 16, 2023
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@skhugh
Copy link
Contributor

skhugh commented Oct 17, 2023

I didn't include tests related to GC since I'm unsure whether exposing garbageCollect() and garbageLength to the public only for benchmark tests is acceptable.

there is VisibleForTesting annotation for exactly for such use-cases.

Base automatically changed from gc to main October 17, 2023 11:43
@7hong13
Copy link
Contributor Author

7hong13 commented Oct 17, 2023

I added the omitted tests for GC using VisibleForTesting in 423d169.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d244681) 78.22% compared to head (ced2773) 78.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files          63       63           
  Lines        3678     3679    +1     
  Branches      573      573           
=======================================
+ Hits         2877     2878    +1     
  Misses        503      503           
  Partials      298      298           
Files Coverage Δ
...ie/src/main/kotlin/dev/yorkie/document/Document.kt 70.55% <ø> (ø)
...c/main/kotlin/dev/yorkie/document/crdt/CrdtTree.kt 82.05% <100.00%> (+0.05%) ⬆️
...lin/dev/yorkie/document/crdt/CrdtTreeExtensions.kt 100.00% <100.00%> (ø)
...main/kotlin/dev/yorkie/document/time/TimeTicket.kt 94.11% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@7hong13 7hong13 merged commit 6782b5c into main Oct 17, 2023
7 checks passed
@7hong13 7hong13 deleted the tree branch October 17, 2023 12:38
@7hong13 7hong13 added this to the 0.4.7 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants