Support concurrent formatting of Text #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerwins
approved these changes
Oct 17, 2023
skhugh
reviewed
Oct 17, 2023
| @@ -75,14 +75,32 @@ internal data class CrdtText( | |||
| range: RgaTreeSplitPosRange, | |||
| attributes: Map<String, String>, | |||
| executedAt: TimeTicket, | |||
| ): List<TextChange> { | |||
| latestCreatedAtMapByActor: Map<ActorID, TimeTicket>? = null, | |||
| ): Pair<Map<ActorID, TimeTicket>, List<TextChange>> { | |||
There was a problem hiding this comment.
I think the return type is getting too complex now 🤔
It would be better to implement a custom class.
There was a problem hiding this comment.
I added TextOperationResult which can be used as the return type for both edit() and style(): 3b2ca89
skhugh
approved these changes
Oct 17, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 78.22% 78.18% -0.05%
==========================================
Files 63 63
Lines 3679 3713 +34
Branches 573 579 +6
==========================================
+ Hits 2878 2903 +25
- Misses 503 506 +3
- Partials 298 304 +6
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Support concurrent formatting of Text.
Any background context you want to provide?
I'll change the base branch to
mainaftergcis merged.What are the relevant tickets?
Fixes #
Checklist