Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary toPath in TreeStyleOpInfo #150

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Remove unnecessary toPath in TreeStyleOpInfo #150

merged 4 commits into from
Jan 19, 2024

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Jan 19, 2024

What this PR does / why we need it?

  • removed the toPath in TreeStyleOpInfo to sync with yorkie-js-sdk.
  • added test annotations to prevent TooManyRequestsException during the execution of instrumentation tests.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 self-assigned this Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (5989f50) 78.46% compared to head (119e176) 79.59%.
Report is 2 commits behind head on main.

Files Patch % Lines
...c/main/kotlin/dev/yorkie/document/crdt/CrdtTree.kt 83.33% 4 Missing and 28 partials ⚠️
...c/main/kotlin/dev/yorkie/document/json/JsonTree.kt 80.00% 2 Missing ⚠️
...orkie/src/main/kotlin/dev/yorkie/util/IndexTree.kt 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   78.46%   79.59%   +1.12%     
==========================================
  Files          63       63              
  Lines        3743     3837      +94     
  Branches      582      601      +19     
==========================================
+ Hits         2937     3054     +117     
+ Misses        500      459      -41     
- Partials      306      324      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@7hong13 7hong13 marked this pull request as ready for review January 19, 2024 03:57
@7hong13 7hong13 requested review from hackerwins and skhugh January 19, 2024 03:57
@7hong13 7hong13 merged commit 7531f9f into main Jan 19, 2024
6 checks passed
@7hong13 7hong13 deleted the tree_style branch January 19, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants