Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect interface changes of server DB sharding #152

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Jan 22, 2024

What this PR does / why we need it?

This PR reflects interface changes due to the DB sharding of the server (yorkie-team/yorkie#734).

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 requested review from hackerwins and skhugh January 22, 2024 02:23
@7hong13 7hong13 self-assigned this Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7531f9f) 79.59% compared to head (d90cd2d) 79.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   79.59%   79.62%   +0.03%     
==========================================
  Files          63       63              
  Lines        3837     3843       +6     
  Branches      601      601              
==========================================
+ Hits         3054     3060       +6     
  Misses        459      459              
  Partials      324      324              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@skhugh skhugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@7hong13 7hong13 merged commit 47b2323 into main Jan 22, 2024
6 checks passed
@7hong13 7hong13 deleted the reflect_db_sharding branch January 22, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants