Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore interface changes due to server DB sharding #155

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Jan 31, 2024

What this PR does / why we need it?

This PR restores passing sharding keys to the SDK in accordance with yorkie-team/yorkie#776.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 requested review from hackerwins and skhugh January 31, 2024 05:19
@7hong13 7hong13 self-assigned this Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8661963) 79.62% compared to head (8ceaa2d) 79.59%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   79.62%   79.59%   -0.04%     
==========================================
  Files          63       63              
  Lines        3853     3847       -6     
  Branches      603      603              
==========================================
- Hits         3068     3062       -6     
  Misses        459      459              
  Partials      326      326              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@7hong13 7hong13 added this to the 0.4.15 milestone Jan 31, 2024
@7hong13 7hong13 merged commit 767c3b4 into main Jan 31, 2024
6 checks passed
@7hong13 7hong13 deleted the db_sharding branch January 31, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants