Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generic warning at Xcode 15 #122

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix generic warning at Xcode 15 #122

merged 1 commit into from
Oct 19, 2023

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Oct 17, 2023

What this PR does / why we need it:

  • Fix misused generic declaration.
    • It has no problem now. but could be an error with Swift 6

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum added this to the 0.4.7 milestone Oct 17, 2023
@humdrum humdrum requested a review from myupage October 17, 2023 09:22
@humdrum humdrum self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f15db57) 43.11% compared to head (21a9f4f) 43.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   43.11%   43.11%           
=======================================
  Files         103      103           
  Lines       22813    22813           
=======================================
  Hits         9835     9835           
  Misses      12978    12978           
Files Coverage Δ
Sources/Util/LLRBTree.swift 86.68% <89.47%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@myupage myupage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@humdrum humdrum merged commit bd6c49b into main Oct 19, 2023
@humdrum humdrum deleted the xcode_15 branch October 19, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants