Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toJSONString to JSONTreeNode #126

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Add toJSONString to JSONTreeNode #126

merged 2 commits into from
Nov 2, 2023

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Nov 2, 2023

What this PR does / why we need it:

  • Add toJSONString to JSONTreeNode, so The user can get the changes by operations.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum requested review from hackerwins and myupage November 2, 2023 07:31
@humdrum humdrum self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (d80ad48) 42.98% compared to head (d15801d) 43.02%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   42.98%   43.02%   +0.04%     
==========================================
  Files         103      104       +1     
  Lines       22840    22932      +92     
==========================================
+ Hits         9817     9866      +49     
- Misses      13023    13066      +43     
Files Coverage Δ
Tests/Unit/Document/JONSTreeTests.swift 100.00% <100.00%> (ø)
Sources/Document/Json/JSONTree.swift 21.89% <70.27%> (+4.78%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Copy link
Contributor

@myupage myupage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@humdrum humdrum merged commit 4a63cca into main Nov 2, 2023
2 checks passed
@humdrum humdrum deleted the json_tree_node_to_json branch November 2, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants