Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more GC tests to reflect current server modifications #130

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Dec 18, 2023

What this PR does / why we need it:

Add more GC tests to reflect current server modifications

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum requested a review from hackerwins December 18, 2023 02:40
@humdrum humdrum self-assigned this Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (f549844) 43.31% compared to head (09134fe) 43.18%.

Files Patch % Lines
Tests/Integration/GCTests.swift 0.00% 70 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   43.31%   43.18%   -0.14%     
==========================================
  Files         104      104              
  Lines       22972    23042      +70     
==========================================
  Hits         9951     9951              
- Misses      13021    13091      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humdrum humdrum requested a review from myupage January 17, 2024 06:47
@humdrum humdrum merged commit ec8868f into main Jan 17, 2024
3 checks passed
@humdrum humdrum deleted the add-more-gc-test branch January 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants