Add forced sync when switching to realtime mode #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 43.31% 43.16% -0.15%
==========================================
Files 104 104
Lines 22972 23051 +79
==========================================
Hits 9951 9951
- Misses 13021 13100 +79 ☔ View full report in Codecov by Sentry. |
chacha912
reviewed
Jan 4, 2024
Sources/Core/Client.swift
Outdated
Comment on lines
478
to
483
| // NOTE(chacha912): When re-establishing real-time sync, there might have been | ||
| // changes while the connection was off. Therefore, syncing needs to be performed | ||
| // once. Currently, if syncing is called here, it overlaps with `syncInternal`, | ||
| // causing the issue of the response being applied twice. (Ref: issues#603) | ||
| // Therefore, we set `remoteChangeEventReceived` to true, allowing syncing to | ||
| // occur in `syncInternal`. |
There was a problem hiding this comment.
The comment has updated.
yorkie-team/yorkie-js-sdk#713
There was a problem hiding this comment.
@chacha912 I changed the comment. Thanks.
humdrum
changed the title
chacha912
approved these changes
Jan 4, 2024
hackerwins
reviewed
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously, when using
resume, remote changes made during thepausewere not being applied. After resuming, if there have been any local or remote changes, a sync is triggered, and previous changes are applied.This PR addresses this issue by triggering a sync during
resume.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: