-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add README and thumbnail on example 'simultaneous-cursors' #683
Conversation
Concurrent case handling for Yorkie.tree (yorkie-team#611)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
My personal opinion: how about changing text on the thumbnail to English so that many people can understand?
Seems like CI is failing. I'm having same issue on my local environment. Any ideas? |
The problem is related to golang/go#58550. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 67.92% 67.89% -0.03%
==========================================
Files 58 58
Lines 8747 8747
Branches 788 788
==========================================
- Hits 5941 5939 -2
- Misses 2547 2548 +1
- Partials 259 260 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
What this PR does / why we need it?
Add README.md and thumbnail.jpg on example
simultaneous-cursors
.There's no any docs on example
simultaneous-cursors
, and I need thumbnail and description to solve those issue.Any background context you want to provide?
What are the relevant tickets?
Fixes #682
Checklist