-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock version of @codemirror/view
to prevent potential issues with Korean character input
#890
Conversation
WalkthroughThe changes involve updates to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
Files selected for processing (1)
- examples/vanilla-codemirror6/package.json (1 hunks)
Additional comments not posted (3)
examples/vanilla-codemirror6/package.json (3)
16-16
: LGTM!The change locks the version of
@codemirror/commands
to an exact version, which aligns with the PR objective of preventing potential issues related to Korean character input.
20-20
: LGTM!The change updates the version of
@codemirror/state
to a newer version, which may include enhancements or bug fixes. This aligns with the PR summary, which mentions updating the version to address compatibility concerns.
21-21
: LGTM!The change locks the version of
@codemirror/view
to an exact version, which aligns with the PR objective of preventing potential issues related to Korean character input. This is consistent with the PR summary and the linked issue #889.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
What this PR does / why we need it?
Lock the version of
@codemirror/commands
and@codemirror/view
@codemirror/commands
:6.1.2
@codemirror/view
:6.23.1
And to address compatibility issues, the A dependency was also updated.
@codemirror/state
:^6.4.1
Any background context you want to provide?
With recent updates to
@codemirror/view
, there is a potential issue where the input of Korean consonants and vowels may lead to incorrect position updates, even though it is not currently occurring. To mitigate the risk of future incidents, it is necessary to explicitly lock the version of@codemirror/view
and related packages to prevent unintended upgrades due to Semantic Versioning.What are the relevant tickets?
Fixes #889
Checklist
Summary by CodeRabbit