Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#108] Fix alert code block #112

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

daisy142
Copy link
Contributor

@daisy142 daisy142 commented Nov 14, 2023

What this PR does / why we need it?

  • Add css selector > for alert icon

To fix the broken layout of copy icon button in alert codeblock.
It should not be overridden by alert's icon styles.

  • Add width and max-width to alert styles

To fix the overflow width of alert codeblock. It should be 100%
if less than view width, and fit-content if greater than viewWidth.

Screenshots:

Screen.Recording.2023-11-14.at.16.30.43.mov

Any background context you want to provide?

What are the relevant tickets?

Fixes #108

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@daisy142 daisy142 added bug 🐞 Something isn't working good first issue 🐤 Good for newcomers labels Nov 14, 2023
@daisy142 daisy142 requested a review from hackerwins November 14, 2023 09:36
@daisy142 daisy142 self-assigned this Nov 14, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 14, 2023

CLA assistant check
All committers have signed the CLA.

@daisy142 daisy142 requested a review from vitran12 November 14, 2023 09:36
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. 👍

@hackerwins hackerwins merged commit a6b9ce0 into main Nov 15, 2023
2 checks passed
@hackerwins hackerwins deleted the bugfix/daisy-fix-alert-codeblock branch November 15, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working good first issue 🐤 Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code blocks within alert boxes on the document page appear ugly
3 participants