-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for android v0.4.24 #139
Conversation
WalkthroughThe recent update focuses on enhancing both the environment setup and documentation for an Android SDK. The Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant SDK
participant DocumentSystem
Developer->>SDK: Initialize with syncMode
SDK->>DocumentSystem: Attach document with specified syncMode
DocumentSystem-->>SDK: Acknowledge attachment
Developer->>SDK: changeSyncMode(newMode)
SDK->>DocumentSystem: Update syncMode to newMode
DocumentSystem-->>SDK: Confirm syncMode change
Note right of SDK: Handles real-time events and subscriptions
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Outside diff range and nitpick comments (1)
docs/android-sdk.mdx (1)
Line range hint
34-34
: Address typographical issues in the documentation.The phrase "client based events" should be hyphenated to "client-based events" for better readability and correctness.
Tools
LanguageTool
[uncategorized] ~81-~81: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...rgument is options. -initialPresence
: Sets the initial presence of the client...
[style] ~97-~97: Consider shortening or rephrasing this to strengthen your wording. (MAKE_CHANGES)
Context: ...Document.update()` method allows you to make changes to the state of the current user's presenc...
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .env (1 hunks)
- docs/android-sdk.mdx (6 hunks)
Files skipped from review due to trivial changes (1)
- .env
Additional context used
LanguageTool
docs/android-sdk.mdx
[uncategorized] ~34-~34: This expression is usually spelled with a hyphen. (BASED_HYPHEN)
Context: ...can useclient.events
to subscribe to client based events, such asstatus
, `streamConnec...
[uncategorized] ~81-~81: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...rgument is options. -initialPresence
: Sets the initial presence of the client...
[style] ~97-~97: Consider shortening or rephrasing this to strengthen your wording. (MAKE_CHANGES)
Context: ...Document.update()` method allows you to make changes to the state of the current user's presenc...
[uncategorized] ~153-~153: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...erIsInstance<PresenceChange.MyPresnece>:
Initialized,
PresenceChanged-
doc...
[uncategorized] ~192-~192: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE)
Context: ...is modified, change events are triggered and we can subscribe to these events using ...
[grammar] ~235-~235: It appears that a hyphen is missing in the plural noun “to-dos”? (TO_DO_HYPHEN)
Context: ...ts(path)with a path argument, such as
$.todos, where the
$` sign indicates the root...
[uncategorized] ~258-~258: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...e server. -SyncMode.RealtimePushOnly
: Only -SyncMode.RealtimeSyncOff
: Ch...
[uncategorized] ~260-~260: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...ly: Only -
SyncMode.RealtimeSyncOff`: Changes are not synchronized, but the w...
[uncategorized] ~262-~262: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...eam remains active. -SyncMode.Manual
: Synchronization no longer occurs in rea...
[style] ~293-~293: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...s such asJsonObject
andJsonArray
. Custom CRDT types can be created in the callba...
Additional comments not posted (2)
docs/android-sdk.mdx (2)
200-216
: Detail the operations within document change events.The documentation now includes detailed explanations of operations within document change events (
LocalChange
,RemoteChange
,Snapshot
). This enhancement will significantly aid developers in understanding and handling these events more effectively.
253-276
: Validate the implementation of new synchronization modes.This verification is necessary to ensure that the new synchronization modes are implemented correctly and are being used as intended in the SDK.
Tools
LanguageTool
[uncategorized] ~258-~258: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...e server. -SyncMode.RealtimePushOnly
: Only -SyncMode.RealtimeSyncOff
: Ch...
[uncategorized] ~260-~260: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...ly: Only -
SyncMode.RealtimeSyncOff`: Changes are not synchronized, but the w...
[uncategorized] ~262-~262: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...eam remains active. -SyncMode.Manual
: Synchronization no longer occurs in rea...
What this PR does / why we need it?
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist
Summary by CodeRabbit
New Features
RealtimePushOnly
andRealtimeSyncOff
for more granular control.client.changeSyncMode(doc, syncMode)
to allow changing synchronization modes dynamically.Snapshot
event.Documentation
Chores
0.4.16
to0.4.24
.