Skip to content

Port concurrent editing of Tree.Edit from JS SDK #1928

Port concurrent editing of Tree.Edit from JS SDK

Port concurrent editing of Tree.Edit from JS SDK #1928

Triggered via pull request August 11, 2023 08:54
Status Failure
Total duration 2m 18s
Artifacts

ci.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

10 errors
build (1.19.2): pkg/document/crdt/tree_test.go#L88
not enough arguments in call to left.Split
build (1.19.2): pkg/document/crdt/tree.go#L266
Error return value of `n.IndexTreeNode.SetChildren` is not checked (errcheck)
build (1.19.2): pkg/document/crdt/tree.go#L267
Error return value of `split.IndexTreeNode.SetChildren` is not checked (errcheck)
build (1.19.2): pkg/document/crdt/tree.go#L642
Error return value of `fromParent.InsertAt` is not checked (errcheck)
build (1.19.2): pkg/document/crdt/tree.go#L645
Error return value of `fromParent.InsertAfter` is not checked (errcheck)
build (1.19.2): pkg/index/tree.go#L256
exported: exported method Node.ChildIndex should have comment or be unexported (revive)
build (1.19.2): pkg/index/tree.go#L354
exported: comment on exported method Node.FindOffset should be of the form "FindOffset ..." (revive)
build (1.19.2): pkg/index/tree.go#L750
exported: exported method Tree.PathToIndex should have comment or be unexported (revive)
build (1.19.2): pkg/index/tree.go#L372
increment-decrement: should replace refined += 1 with refined++ (revive)
build (1.19.2): pkg/document/crdt/tree.go#L37
exported: comment on exported var DummyTreeNodeId should be of the form "DummyTreeNodeId ..." (revive)