Skip to content

Commit

Permalink
Revise client mock test
Browse files Browse the repository at this point in the history
  • Loading branch information
@krapie
krapie committed Dec 7, 2023
1 parent 1f22ad8 commit 24b7b44
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
6 changes: 5 additions & 1 deletion admin/client.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,11 @@ func Dial(rpcAddr string, opts ...Option) (*Client, error) {
// Dial dials to the admin service.
func (c *Client) Dial(rpcAddr string) error {
c.conn = http.DefaultClient
c.client = v1connect.NewAdminServiceClient(c.conn, "http://"+rpcAddr, connect.WithInterceptors(c.authInterceptor))
c.client = v1connect.NewAdminServiceClient(
c.conn,
fmt.Sprintf("http://%s", rpcAddr),
connect.WithInterceptors(c.authInterceptor),
)

return nil
}
Expand Down
6 changes: 5 additions & 1 deletion client/client.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,11 @@ func Dial(rpcAddr string, opts ...Option) (*Client, error) {
// Dial dials the given rpcAddr.
func (c *Client) Dial(rpcAddr string) error {
c.conn = http.DefaultClient
c.client = v1connect.NewYorkieServiceClient(c.conn, "http://"+rpcAddr, c.clientOptions...)
c.client = v1connect.NewYorkieServiceClient(
c.conn,
fmt.Sprintf("http://%s", rpcAddr),
c.clientOptions...,
)

return nil
}
Expand Down
3 changes: 1 addition & 2 deletions client/client_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
"testing"

"connectrpc.com/connect"

"github.com/rs/xid"
"github.com/stretchr/testify/assert"
monkey "github.com/undefinedlabs/go-mpatch"
Expand All @@ -47,7 +46,7 @@ type testYorkieServer struct {
func dialTestYorkieServer() (*testYorkieServer, string) {
yorkieServer := &v1connect.UnimplementedYorkieServiceHandler{}
mux := http.NewServeMux()
mux.Handle(v1connect.NewYorkieServiceHandler(yorkieServer, nil))
mux.Handle(v1connect.NewYorkieServiceHandler(yorkieServer))
httpServer := httptest.NewUnstartedServer(mux)

testYorkieServer := &testYorkieServer{
Expand Down

1 comment on commit 24b7b44

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Benchmark

Benchmark suite Current: 24b7b44 Previous: 3ebef65 Ratio
BenchmarkDocument/constructor_test - ns/op 1335 ns/op 1373 ns/op 0.97
BenchmarkDocument/constructor_test - B/op 1208 B/op 1208 B/op 1
BenchmarkDocument/constructor_test - allocs/op 20 allocs/op 20 allocs/op 1
BenchmarkDocument/status_test - ns/op 804.1 ns/op 796.5 ns/op 1.01
BenchmarkDocument/status_test - B/op 1176 B/op 1176 B/op 1
BenchmarkDocument/status_test - allocs/op 18 allocs/op 18 allocs/op 1
BenchmarkDocument/equals_test - ns/op 8309 ns/op 8302 ns/op 1.00
BenchmarkDocument/equals_test - B/op 6913 B/op 6913 B/op 1
BenchmarkDocument/equals_test - allocs/op 120 allocs/op 120 allocs/op 1
BenchmarkDocument/nested_update_test - ns/op 16211 ns/op 16598 ns/op 0.98
BenchmarkDocument/nested_update_test - B/op 11962 B/op 11962 B/op 1
BenchmarkDocument/nested_update_test - allocs/op 254 allocs/op 254 allocs/op 1
BenchmarkDocument/delete_test - ns/op 22120 ns/op 22626 ns/op 0.98
BenchmarkDocument/delete_test - B/op 15187 B/op 15188 B/op 1.00
BenchmarkDocument/delete_test - allocs/op 333 allocs/op 333 allocs/op 1
BenchmarkDocument/object_test - ns/op 8405 ns/op 8699 ns/op 0.97
BenchmarkDocument/object_test - B/op 6721 B/op 6721 B/op 1
BenchmarkDocument/object_test - allocs/op 116 allocs/op 116 allocs/op 1
BenchmarkDocument/array_test - ns/op 29069 ns/op 29401 ns/op 0.99
BenchmarkDocument/array_test - B/op 11819 B/op 11819 B/op 1
BenchmarkDocument/array_test - allocs/op 270 allocs/op 270 allocs/op 1
BenchmarkDocument/text_test - ns/op 30481 ns/op 31226 ns/op 0.98
BenchmarkDocument/text_test - B/op 14795 B/op 14795 B/op 1
BenchmarkDocument/text_test - allocs/op 468 allocs/op 468 allocs/op 1
BenchmarkDocument/text_composition_test - ns/op 28944 ns/op 29299 ns/op 0.99
BenchmarkDocument/text_composition_test - B/op 18278 B/op 18278 B/op 1
BenchmarkDocument/text_composition_test - allocs/op 477 allocs/op 477 allocs/op 1
BenchmarkDocument/rich_text_test - ns/op 81180 ns/op 82820 ns/op 0.98
BenchmarkDocument/rich_text_test - B/op 38540 B/op 38540 B/op 1
BenchmarkDocument/rich_text_test - allocs/op 1147 allocs/op 1147 allocs/op 1
BenchmarkDocument/counter_test - ns/op 16891 ns/op 17386 ns/op 0.97
BenchmarkDocument/counter_test - B/op 10210 B/op 10210 B/op 1
BenchmarkDocument/counter_test - allocs/op 236 allocs/op 236 allocs/op 1
BenchmarkDocument/text_edit_gc_100 - ns/op 2939763 ns/op 2970186 ns/op 0.99
BenchmarkDocument/text_edit_gc_100 - B/op 1655281 B/op 1655326 B/op 1.00
BenchmarkDocument/text_edit_gc_100 - allocs/op 17093 allocs/op 17093 allocs/op 1
BenchmarkDocument/text_edit_gc_1000 - ns/op 228425010 ns/op 231735416 ns/op 0.99
BenchmarkDocument/text_edit_gc_1000 - B/op 144353102 B/op 144366033 B/op 1.00
BenchmarkDocument/text_edit_gc_1000 - allocs/op 200940 allocs/op 201007 allocs/op 1.00
BenchmarkDocument/text_split_gc_100 - ns/op 3391232 ns/op 3385194 ns/op 1.00
BenchmarkDocument/text_split_gc_100 - B/op 2313655 B/op 2313331 B/op 1.00
BenchmarkDocument/text_split_gc_100 - allocs/op 16195 allocs/op 16194 allocs/op 1.00
BenchmarkDocument/text_split_gc_1000 - ns/op 291313878 ns/op 296761342 ns/op 0.98
BenchmarkDocument/text_split_gc_1000 - B/op 228894776 B/op 228881832 B/op 1.00
BenchmarkDocument/text_split_gc_1000 - allocs/op 203973 allocs/op 203904 allocs/op 1.00
BenchmarkDocument/text_delete_all_10000 - ns/op 11447144 ns/op 11146892 ns/op 1.03
BenchmarkDocument/text_delete_all_10000 - B/op 5811581 B/op 5810543 B/op 1.00
BenchmarkDocument/text_delete_all_10000 - allocs/op 40679 allocs/op 40675 allocs/op 1.00
BenchmarkDocument/text_delete_all_100000 - ns/op 178039240 ns/op 187188955 ns/op 0.95
BenchmarkDocument/text_delete_all_100000 - B/op 81891888 B/op 81887592 B/op 1.00
BenchmarkDocument/text_delete_all_100000 - allocs/op 411584 allocs/op 411550 allocs/op 1.00
BenchmarkDocument/text_100 - ns/op 220757 ns/op 232235 ns/op 0.95
BenchmarkDocument/text_100 - B/op 118483 B/op 118483 B/op 1
BenchmarkDocument/text_100 - allocs/op 5080 allocs/op 5080 allocs/op 1
BenchmarkDocument/text_1000 - ns/op 2387800 ns/op 2502773 ns/op 0.95
BenchmarkDocument/text_1000 - B/op 1153068 B/op 1153073 B/op 1.00
BenchmarkDocument/text_1000 - allocs/op 50084 allocs/op 50084 allocs/op 1
BenchmarkDocument/array_1000 - ns/op 1180610 ns/op 1267389 ns/op 0.93
BenchmarkDocument/array_1000 - B/op 1091189 B/op 1091268 B/op 1.00
BenchmarkDocument/array_1000 - allocs/op 11825 allocs/op 11826 allocs/op 1.00
BenchmarkDocument/array_10000 - ns/op 13025213 ns/op 13549731 ns/op 0.96
BenchmarkDocument/array_10000 - B/op 9799962 B/op 9800047 B/op 1.00
BenchmarkDocument/array_10000 - allocs/op 120290 allocs/op 120291 allocs/op 1.00
BenchmarkDocument/array_gc_100 - ns/op 143582 ns/op 153664 ns/op 0.93
BenchmarkDocument/array_gc_100 - B/op 132498 B/op 132498 B/op 1
BenchmarkDocument/array_gc_100 - allocs/op 1248 allocs/op 1248 allocs/op 1
BenchmarkDocument/array_gc_1000 - ns/op 1369158 ns/op 1451255 ns/op 0.94
BenchmarkDocument/array_gc_1000 - B/op 1158960 B/op 1158965 B/op 1.00
BenchmarkDocument/array_gc_1000 - allocs/op 12865 allocs/op 12865 allocs/op 1
BenchmarkDocument/counter_1000 - ns/op 200233 ns/op 215664 ns/op 0.93
BenchmarkDocument/counter_1000 - B/op 192853 B/op 192852 B/op 1.00
BenchmarkDocument/counter_1000 - allocs/op 5765 allocs/op 5765 allocs/op 1
BenchmarkDocument/counter_10000 - ns/op 2167066 ns/op 2222359 ns/op 0.98
BenchmarkDocument/counter_10000 - B/op 2087779 B/op 2087783 B/op 1.00
BenchmarkDocument/counter_10000 - allocs/op 59772 allocs/op 59772 allocs/op 1
BenchmarkDocument/object_1000 - ns/op 1357378 ns/op 1433455 ns/op 0.95
BenchmarkDocument/object_1000 - B/op 1428007 B/op 1427946 B/op 1.00
BenchmarkDocument/object_1000 - allocs/op 9845 allocs/op 9845 allocs/op 1
BenchmarkDocument/object_10000 - ns/op 14644935 ns/op 14878581 ns/op 0.98
BenchmarkDocument/object_10000 - B/op 12165866 B/op 12167003 B/op 1.00
BenchmarkDocument/object_10000 - allocs/op 100557 allocs/op 100561 allocs/op 1.00
BenchmarkDocument/tree_100 - ns/op 1032148 ns/op 722947 ns/op 1.43
BenchmarkDocument/tree_100 - B/op 943674 B/op 442891 B/op 2.13
BenchmarkDocument/tree_100 - allocs/op 6099 allocs/op 4506 allocs/op 1.35
BenchmarkDocument/tree_1000 - ns/op 74789292 ns/op 48715965 ns/op 1.54
BenchmarkDocument/tree_1000 - B/op 86460445 B/op 35222566 B/op 2.45
BenchmarkDocument/tree_1000 - allocs/op 60114 allocs/op 44119 allocs/op 1.36
BenchmarkDocument/tree_10000 - ns/op 9529041853 ns/op 6243742972 ns/op 1.53
BenchmarkDocument/tree_10000 - B/op 8580986440 B/op 3439193776 B/op 2.50
BenchmarkDocument/tree_10000 - allocs/op 600251 allocs/op 440204 allocs/op 1.36
BenchmarkDocument/tree_delete_all_1000 - ns/op 73674804 ns/op 50492483 ns/op 1.46
BenchmarkDocument/tree_delete_all_1000 - B/op 86990492 B/op 35687345 B/op 2.44
BenchmarkDocument/tree_delete_all_1000 - allocs/op 67750 allocs/op 51744 allocs/op 1.31
BenchmarkDocument/tree_edit_gc_100 - ns/op 3689889 ns/op 2674319 ns/op 1.38
BenchmarkDocument/tree_edit_gc_100 - B/op 4120933 B/op 2099522 B/op 1.96
BenchmarkDocument/tree_edit_gc_100 - allocs/op 14356 allocs/op 11165 allocs/op 1.29
BenchmarkDocument/tree_edit_gc_1000 - ns/op 306035149 ns/op 200656697 ns/op 1.53
BenchmarkDocument/tree_edit_gc_1000 - B/op 383467156 B/op 180293307 B/op 2.13
BenchmarkDocument/tree_edit_gc_1000 - allocs/op 145419 allocs/op 113350 allocs/op 1.28
BenchmarkDocument/tree_split_gc_100 - ns/op 2460941 ns/op 1969140 ns/op 1.25
BenchmarkDocument/tree_split_gc_100 - B/op 2386764 B/op 1363475 B/op 1.75
BenchmarkDocument/tree_split_gc_100 - allocs/op 10340 allocs/op 8735 allocs/op 1.18
BenchmarkDocument/tree_split_gc_1000 - ns/op 183265722 ns/op 133034523 ns/op 1.38
BenchmarkDocument/tree_split_gc_1000 - B/op 221990610 B/op 120284053 B/op 1.85
BenchmarkDocument/tree_split_gc_1000 - allocs/op 112252 allocs/op 96193 allocs/op 1.17
BenchmarkRPC/client_to_server - ns/op 354131714 ns/op 356375965 ns/op 0.99
BenchmarkRPC/client_to_server - B/op 17729429 B/op 16323573 B/op 1.09
BenchmarkRPC/client_to_server - allocs/op 165499 allocs/op 165420 allocs/op 1.00
BenchmarkRPC/client_to_client_via_server - ns/op 592384370 ns/op 607723810 ns/op 0.97
BenchmarkRPC/client_to_client_via_server - B/op 32667180 B/op 34041892 B/op 0.96
BenchmarkRPC/client_to_client_via_server - allocs/op 308885 allocs/op 309871 allocs/op 1.00
BenchmarkRPC/attach_large_document - ns/op 1195267127 ns/op 1463602622 ns/op 0.82
BenchmarkRPC/attach_large_document - B/op 1879459032 B/op 1878647264 B/op 1.00
BenchmarkRPC/attach_large_document - allocs/op 7104 allocs/op 7043 allocs/op 1.01
BenchmarkRPC/adminCli_to_server - ns/op 534389117 ns/op 541741676 ns/op 0.99
BenchmarkRPC/adminCli_to_server - B/op 35562520 B/op 36380716 B/op 0.98
BenchmarkRPC/adminCli_to_server - allocs/op 284589 allocs/op 284616 allocs/op 1.00
BenchmarkLocker - ns/op 66.25 ns/op 65.29 ns/op 1.01
BenchmarkLocker - B/op 16 B/op 16 B/op 1
BenchmarkLocker - allocs/op 1 allocs/op 1 allocs/op 1
BenchmarkLockerParallel - ns/op 38.92 ns/op 38.64 ns/op 1.01
BenchmarkLockerParallel - B/op 0 B/op 0 B/op NaN
BenchmarkLockerParallel - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkLockerMoreKeys - ns/op 154.8 ns/op 138.5 ns/op 1.12
BenchmarkLockerMoreKeys - B/op 15 B/op 15 B/op 1
BenchmarkLockerMoreKeys - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkChange/Push_10_Changes - ns/op 3757810 ns/op 3779429 ns/op 0.99
BenchmarkChange/Push_10_Changes - B/op 126366 B/op 126275 B/op 1.00
BenchmarkChange/Push_10_Changes - allocs/op 1253 allocs/op 1254 allocs/op 1.00
BenchmarkChange/Push_100_Changes - ns/op 14026992 ns/op 14129092 ns/op 0.99
BenchmarkChange/Push_100_Changes - B/op 645669 B/op 646942 B/op 1.00
BenchmarkChange/Push_100_Changes - allocs/op 6537 allocs/op 6540 allocs/op 1.00
BenchmarkChange/Push_1000_Changes - ns/op 112896892 ns/op 113213707 ns/op 1.00
BenchmarkChange/Push_1000_Changes - B/op 5993306 B/op 6011043 B/op 1.00
BenchmarkChange/Push_1000_Changes - allocs/op 62159 allocs/op 62155 allocs/op 1.00
BenchmarkChange/Pull_10_Changes - ns/op 2852002 ns/op 2837624 ns/op 1.01
BenchmarkChange/Pull_10_Changes - B/op 100893 B/op 100327 B/op 1.01
BenchmarkChange/Pull_10_Changes - allocs/op 952 allocs/op 951 allocs/op 1.00
BenchmarkChange/Pull_100_Changes - ns/op 4338959 ns/op 4303014 ns/op 1.01
BenchmarkChange/Pull_100_Changes - B/op 258512 B/op 257269 B/op 1.00
BenchmarkChange/Pull_100_Changes - allocs/op 3154 allocs/op 3154 allocs/op 1
BenchmarkChange/Pull_1000_Changes - ns/op 8520560 ns/op 8473189 ns/op 1.01
BenchmarkChange/Pull_1000_Changes - B/op 1394047 B/op 1393414 B/op 1.00
BenchmarkChange/Pull_1000_Changes - allocs/op 26871 allocs/op 26869 allocs/op 1.00
BenchmarkSnapshot/Push_3KB_snapshot - ns/op 16729282 ns/op 16717315 ns/op 1.00
BenchmarkSnapshot/Push_3KB_snapshot - B/op 802636 B/op 807884 B/op 0.99
BenchmarkSnapshot/Push_3KB_snapshot - allocs/op 6544 allocs/op 6541 allocs/op 1.00
BenchmarkSnapshot/Push_30KB_snapshot - ns/op 116533892 ns/op 117501595 ns/op 0.99
BenchmarkSnapshot/Push_30KB_snapshot - B/op 6296279 B/op 6250940 B/op 1.01
BenchmarkSnapshot/Push_30KB_snapshot - allocs/op 62162 allocs/op 62161 allocs/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - ns/op 6593453 ns/op 6521588 ns/op 1.01
BenchmarkSnapshot/Pull_3KB_snapshot - B/op 905742 B/op 904310 B/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - allocs/op 14876 allocs/op 14878 allocs/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - ns/op 15114728 ns/op 15228711 ns/op 0.99
BenchmarkSnapshot/Pull_30KB_snapshot - B/op 6983778 B/op 6983077 B/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - allocs/op 144138 allocs/op 144141 allocs/op 1.00
BenchmarkSync/memory_sync_10_test - ns/op 6829 ns/op 6917 ns/op 0.99
BenchmarkSync/memory_sync_10_test - B/op 1286 B/op 1286 B/op 1
BenchmarkSync/memory_sync_10_test - allocs/op 38 allocs/op 38 allocs/op 1
BenchmarkSync/memory_sync_100_test - ns/op 52893 ns/op 51493 ns/op 1.03
BenchmarkSync/memory_sync_100_test - B/op 8638 B/op 8650 B/op 1.00
BenchmarkSync/memory_sync_100_test - allocs/op 273 allocs/op 273 allocs/op 1
BenchmarkSync/memory_sync_1000_test - ns/op 579902 ns/op 598451 ns/op 0.97
BenchmarkSync/memory_sync_1000_test - B/op 75064 B/op 74330 B/op 1.01
BenchmarkSync/memory_sync_1000_test - allocs/op 2150 allocs/op 2108 allocs/op 1.02
BenchmarkSync/memory_sync_10000_test - ns/op 7153127 ns/op 7141413 ns/op 1.00
BenchmarkSync/memory_sync_10000_test - B/op 760750 B/op 761330 B/op 1.00
BenchmarkSync/memory_sync_10000_test - allocs/op 20535 allocs/op 20560 allocs/op 1.00
BenchmarkTextEditing - ns/op 18284769919 ns/op 19117165431 ns/op 0.96
BenchmarkTextEditing - B/op 9037753112 B/op 9037584392 B/op 1.00
BenchmarkTextEditing - allocs/op 19922238 allocs/op 19921383 allocs/op 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.