Skip to content

Commit

Permalink
Revise client mock test
Browse files Browse the repository at this point in the history
  • Loading branch information
@krapie
krapie committed Dec 7, 2023
1 parent 1f22ad8 commit 464e53f
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
6 changes: 5 additions & 1 deletion admin/client.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,12 @@ func Dial(rpcAddr string, opts ...Option) (*Client, error) {

// Dial dials to the admin service.
func (c *Client) Dial(rpcAddr string) error {
if !strings.HasPrefix(rpcAddr, "http") {
rpcAddr = "http://" + rpcAddr
}

c.conn = http.DefaultClient
c.client = v1connect.NewAdminServiceClient(c.conn, "http://"+rpcAddr, connect.WithInterceptors(c.authInterceptor))
c.client = v1connect.NewAdminServiceClient(c.conn, rpcAddr, connect.WithInterceptors(c.authInterceptor))

return nil
}
Expand Down
6 changes: 5 additions & 1 deletion client/client.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,12 @@ func Dial(rpcAddr string, opts ...Option) (*Client, error) {

// Dial dials the given rpcAddr.
func (c *Client) Dial(rpcAddr string) error {
if !strings.HasPrefix(rpcAddr, "http") {
rpcAddr = "http://" + rpcAddr
}

c.conn = http.DefaultClient
c.client = v1connect.NewYorkieServiceClient(c.conn, "http://"+rpcAddr, c.clientOptions...)
c.client = v1connect.NewYorkieServiceClient(c.conn, rpcAddr, c.clientOptions...)

return nil
}
Expand Down
3 changes: 1 addition & 2 deletions client/client_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
"testing"

"connectrpc.com/connect"

"github.com/rs/xid"
"github.com/stretchr/testify/assert"
monkey "github.com/undefinedlabs/go-mpatch"
Expand All @@ -47,7 +46,7 @@ type testYorkieServer struct {
func dialTestYorkieServer() (*testYorkieServer, string) {
yorkieServer := &v1connect.UnimplementedYorkieServiceHandler{}
mux := http.NewServeMux()
mux.Handle(v1connect.NewYorkieServiceHandler(yorkieServer, nil))
mux.Handle(v1connect.NewYorkieServiceHandler(yorkieServer))
httpServer := httptest.NewUnstartedServer(mux)

testYorkieServer := &testYorkieServer{
Expand Down

1 comment on commit 464e53f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Benchmark

Benchmark suite Current: 464e53f Previous: 3ebef65 Ratio
BenchmarkDocument/constructor_test - ns/op 1326 ns/op 1373 ns/op 0.97
BenchmarkDocument/constructor_test - B/op 1208 B/op 1208 B/op 1
BenchmarkDocument/constructor_test - allocs/op 20 allocs/op 20 allocs/op 1
BenchmarkDocument/status_test - ns/op 795 ns/op 796.5 ns/op 1.00
BenchmarkDocument/status_test - B/op 1176 B/op 1176 B/op 1
BenchmarkDocument/status_test - allocs/op 18 allocs/op 18 allocs/op 1
BenchmarkDocument/equals_test - ns/op 7138 ns/op 8302 ns/op 0.86
BenchmarkDocument/equals_test - B/op 6913 B/op 6913 B/op 1
BenchmarkDocument/equals_test - allocs/op 120 allocs/op 120 allocs/op 1
BenchmarkDocument/nested_update_test - ns/op 16038 ns/op 16598 ns/op 0.97
BenchmarkDocument/nested_update_test - B/op 11962 B/op 11962 B/op 1
BenchmarkDocument/nested_update_test - allocs/op 254 allocs/op 254 allocs/op 1
BenchmarkDocument/delete_test - ns/op 24856 ns/op 22626 ns/op 1.10
BenchmarkDocument/delete_test - B/op 15188 B/op 15188 B/op 1
BenchmarkDocument/delete_test - allocs/op 333 allocs/op 333 allocs/op 1
BenchmarkDocument/object_test - ns/op 8319 ns/op 8699 ns/op 0.96
BenchmarkDocument/object_test - B/op 6721 B/op 6721 B/op 1
BenchmarkDocument/object_test - allocs/op 116 allocs/op 116 allocs/op 1
BenchmarkDocument/array_test - ns/op 28739 ns/op 29401 ns/op 0.98
BenchmarkDocument/array_test - B/op 11819 B/op 11819 B/op 1
BenchmarkDocument/array_test - allocs/op 270 allocs/op 270 allocs/op 1
BenchmarkDocument/text_test - ns/op 30625 ns/op 31226 ns/op 0.98
BenchmarkDocument/text_test - B/op 14795 B/op 14795 B/op 1
BenchmarkDocument/text_test - allocs/op 468 allocs/op 468 allocs/op 1
BenchmarkDocument/text_composition_test - ns/op 29914 ns/op 29299 ns/op 1.02
BenchmarkDocument/text_composition_test - B/op 18278 B/op 18278 B/op 1
BenchmarkDocument/text_composition_test - allocs/op 477 allocs/op 477 allocs/op 1
BenchmarkDocument/rich_text_test - ns/op 80404 ns/op 82820 ns/op 0.97
BenchmarkDocument/rich_text_test - B/op 38540 B/op 38540 B/op 1
BenchmarkDocument/rich_text_test - allocs/op 1147 allocs/op 1147 allocs/op 1
BenchmarkDocument/counter_test - ns/op 16678 ns/op 17386 ns/op 0.96
BenchmarkDocument/counter_test - B/op 10210 B/op 10210 B/op 1
BenchmarkDocument/counter_test - allocs/op 236 allocs/op 236 allocs/op 1
BenchmarkDocument/text_edit_gc_100 - ns/op 2912100 ns/op 2970186 ns/op 0.98
BenchmarkDocument/text_edit_gc_100 - B/op 1655345 B/op 1655326 B/op 1.00
BenchmarkDocument/text_edit_gc_100 - allocs/op 17093 allocs/op 17093 allocs/op 1
BenchmarkDocument/text_edit_gc_1000 - ns/op 229053458 ns/op 231735416 ns/op 0.99
BenchmarkDocument/text_edit_gc_1000 - B/op 144336529 B/op 144366033 B/op 1.00
BenchmarkDocument/text_edit_gc_1000 - allocs/op 200884 allocs/op 201007 allocs/op 1.00
BenchmarkDocument/text_split_gc_100 - ns/op 3362647 ns/op 3385194 ns/op 0.99
BenchmarkDocument/text_split_gc_100 - B/op 2313614 B/op 2313331 B/op 1.00
BenchmarkDocument/text_split_gc_100 - allocs/op 16195 allocs/op 16194 allocs/op 1.00
BenchmarkDocument/text_split_gc_1000 - ns/op 289298144 ns/op 296761342 ns/op 0.97
BenchmarkDocument/text_split_gc_1000 - B/op 228919124 B/op 228881832 B/op 1.00
BenchmarkDocument/text_split_gc_1000 - allocs/op 204073 allocs/op 203904 allocs/op 1.00
BenchmarkDocument/text_delete_all_10000 - ns/op 11627408 ns/op 11146892 ns/op 1.04
BenchmarkDocument/text_delete_all_10000 - B/op 5810832 B/op 5810543 B/op 1.00
BenchmarkDocument/text_delete_all_10000 - allocs/op 40675 allocs/op 40675 allocs/op 1
BenchmarkDocument/text_delete_all_100000 - ns/op 179210437 ns/op 187188955 ns/op 0.96
BenchmarkDocument/text_delete_all_100000 - B/op 81901802 B/op 81887592 B/op 1.00
BenchmarkDocument/text_delete_all_100000 - allocs/op 411632 allocs/op 411550 allocs/op 1.00
BenchmarkDocument/text_100 - ns/op 231743 ns/op 232235 ns/op 1.00
BenchmarkDocument/text_100 - B/op 118483 B/op 118483 B/op 1
BenchmarkDocument/text_100 - allocs/op 5080 allocs/op 5080 allocs/op 1
BenchmarkDocument/text_1000 - ns/op 2492682 ns/op 2502773 ns/op 1.00
BenchmarkDocument/text_1000 - B/op 1153072 B/op 1153073 B/op 1.00
BenchmarkDocument/text_1000 - allocs/op 50084 allocs/op 50084 allocs/op 1
BenchmarkDocument/array_1000 - ns/op 1245735 ns/op 1267389 ns/op 0.98
BenchmarkDocument/array_1000 - B/op 1091165 B/op 1091268 B/op 1.00
BenchmarkDocument/array_1000 - allocs/op 11825 allocs/op 11826 allocs/op 1.00
BenchmarkDocument/array_10000 - ns/op 12964124 ns/op 13549731 ns/op 0.96
BenchmarkDocument/array_10000 - B/op 9799793 B/op 9800047 B/op 1.00
BenchmarkDocument/array_10000 - allocs/op 120290 allocs/op 120291 allocs/op 1.00
BenchmarkDocument/array_gc_100 - ns/op 151892 ns/op 153664 ns/op 0.99
BenchmarkDocument/array_gc_100 - B/op 132492 B/op 132498 B/op 1.00
BenchmarkDocument/array_gc_100 - allocs/op 1248 allocs/op 1248 allocs/op 1
BenchmarkDocument/array_gc_1000 - ns/op 1416944 ns/op 1451255 ns/op 0.98
BenchmarkDocument/array_gc_1000 - B/op 1158935 B/op 1158965 B/op 1.00
BenchmarkDocument/array_gc_1000 - allocs/op 12865 allocs/op 12865 allocs/op 1
BenchmarkDocument/counter_1000 - ns/op 215023 ns/op 215664 ns/op 1.00
BenchmarkDocument/counter_1000 - B/op 192853 B/op 192852 B/op 1.00
BenchmarkDocument/counter_1000 - allocs/op 5765 allocs/op 5765 allocs/op 1
BenchmarkDocument/counter_10000 - ns/op 2223707 ns/op 2222359 ns/op 1.00
BenchmarkDocument/counter_10000 - B/op 2087784 B/op 2087783 B/op 1.00
BenchmarkDocument/counter_10000 - allocs/op 59772 allocs/op 59772 allocs/op 1
BenchmarkDocument/object_1000 - ns/op 1417873 ns/op 1433455 ns/op 0.99
BenchmarkDocument/object_1000 - B/op 1428142 B/op 1427946 B/op 1.00
BenchmarkDocument/object_1000 - allocs/op 9845 allocs/op 9845 allocs/op 1
BenchmarkDocument/object_10000 - ns/op 14776371 ns/op 14878581 ns/op 0.99
BenchmarkDocument/object_10000 - B/op 12165694 B/op 12167003 B/op 1.00
BenchmarkDocument/object_10000 - allocs/op 100557 allocs/op 100561 allocs/op 1.00
BenchmarkDocument/tree_100 - ns/op 1085277 ns/op 722947 ns/op 1.50
BenchmarkDocument/tree_100 - B/op 943678 B/op 442891 B/op 2.13
BenchmarkDocument/tree_100 - allocs/op 6099 allocs/op 4506 allocs/op 1.35
BenchmarkDocument/tree_1000 - ns/op 80283036 ns/op 48715965 ns/op 1.65
BenchmarkDocument/tree_1000 - B/op 86460376 B/op 35222566 B/op 2.45
BenchmarkDocument/tree_1000 - allocs/op 60112 allocs/op 44119 allocs/op 1.36
BenchmarkDocument/tree_10000 - ns/op 9953746628 ns/op 6243742972 ns/op 1.59
BenchmarkDocument/tree_10000 - B/op 8580670808 B/op 3439193776 B/op 2.49
BenchmarkDocument/tree_10000 - allocs/op 600226 allocs/op 440204 allocs/op 1.36
BenchmarkDocument/tree_delete_all_1000 - ns/op 81090271 ns/op 50492483 ns/op 1.61
BenchmarkDocument/tree_delete_all_1000 - B/op 87013577 B/op 35687345 B/op 2.44
BenchmarkDocument/tree_delete_all_1000 - allocs/op 67751 allocs/op 51744 allocs/op 1.31
BenchmarkDocument/tree_edit_gc_100 - ns/op 3879653 ns/op 2674319 ns/op 1.45
BenchmarkDocument/tree_edit_gc_100 - B/op 4120965 B/op 2099522 B/op 1.96
BenchmarkDocument/tree_edit_gc_100 - allocs/op 14356 allocs/op 11165 allocs/op 1.29
BenchmarkDocument/tree_edit_gc_1000 - ns/op 335323569 ns/op 200656697 ns/op 1.67
BenchmarkDocument/tree_edit_gc_1000 - B/op 383467824 B/op 180293307 B/op 2.13
BenchmarkDocument/tree_edit_gc_1000 - allocs/op 145425 allocs/op 113350 allocs/op 1.28
BenchmarkDocument/tree_split_gc_100 - ns/op 2601161 ns/op 1969140 ns/op 1.32
BenchmarkDocument/tree_split_gc_100 - B/op 2386808 B/op 1363475 B/op 1.75
BenchmarkDocument/tree_split_gc_100 - allocs/op 10341 allocs/op 8735 allocs/op 1.18
BenchmarkDocument/tree_split_gc_1000 - ns/op 199080274 ns/op 133034523 ns/op 1.50
BenchmarkDocument/tree_split_gc_1000 - B/op 221993925 B/op 120284053 B/op 1.85
BenchmarkDocument/tree_split_gc_1000 - allocs/op 112281 allocs/op 96193 allocs/op 1.17
BenchmarkRPC/client_to_server - ns/op 355875737 ns/op 356375965 ns/op 1.00
BenchmarkRPC/client_to_server - B/op 17497618 B/op 16323573 B/op 1.07
BenchmarkRPC/client_to_server - allocs/op 166541 allocs/op 165420 allocs/op 1.01
BenchmarkRPC/client_to_client_via_server - ns/op 604443466 ns/op 607723810 ns/op 0.99
BenchmarkRPC/client_to_client_via_server - B/op 31521936 B/op 34041892 B/op 0.93
BenchmarkRPC/client_to_client_via_server - allocs/op 311044 allocs/op 309871 allocs/op 1.00
BenchmarkRPC/attach_large_document - ns/op 1308292833 ns/op 1463602622 ns/op 0.89
BenchmarkRPC/attach_large_document - B/op 1889957856 B/op 1878647264 B/op 1.01
BenchmarkRPC/attach_large_document - allocs/op 7151 allocs/op 7043 allocs/op 1.02
BenchmarkRPC/adminCli_to_server - ns/op 536016808 ns/op 541741676 ns/op 0.99
BenchmarkRPC/adminCli_to_server - B/op 35586476 B/op 36380716 B/op 0.98
BenchmarkRPC/adminCli_to_server - allocs/op 285574 allocs/op 284616 allocs/op 1.00
BenchmarkLocker - ns/op 65 ns/op 65.29 ns/op 1.00
BenchmarkLocker - B/op 16 B/op 16 B/op 1
BenchmarkLocker - allocs/op 1 allocs/op 1 allocs/op 1
BenchmarkLockerParallel - ns/op 38.35 ns/op 38.64 ns/op 0.99
BenchmarkLockerParallel - B/op 0 B/op 0 B/op NaN
BenchmarkLockerParallel - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkLockerMoreKeys - ns/op 149.7 ns/op 138.5 ns/op 1.08
BenchmarkLockerMoreKeys - B/op 15 B/op 15 B/op 1
BenchmarkLockerMoreKeys - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkChange/Push_10_Changes - ns/op 3761073 ns/op 3779429 ns/op 1.00
BenchmarkChange/Push_10_Changes - B/op 126209 B/op 126275 B/op 1.00
BenchmarkChange/Push_10_Changes - allocs/op 1253 allocs/op 1254 allocs/op 1.00
BenchmarkChange/Push_100_Changes - ns/op 13966658 ns/op 14129092 ns/op 0.99
BenchmarkChange/Push_100_Changes - B/op 640781 B/op 646942 B/op 0.99
BenchmarkChange/Push_100_Changes - allocs/op 6538 allocs/op 6540 allocs/op 1.00
BenchmarkChange/Push_1000_Changes - ns/op 112742027 ns/op 113213707 ns/op 1.00
BenchmarkChange/Push_1000_Changes - B/op 6075442 B/op 6011043 B/op 1.01
BenchmarkChange/Push_1000_Changes - allocs/op 62158 allocs/op 62155 allocs/op 1.00
BenchmarkChange/Pull_10_Changes - ns/op 2837814 ns/op 2837624 ns/op 1.00
BenchmarkChange/Pull_10_Changes - B/op 100504 B/op 100327 B/op 1.00
BenchmarkChange/Pull_10_Changes - allocs/op 952 allocs/op 951 allocs/op 1.00
BenchmarkChange/Pull_100_Changes - ns/op 4368902 ns/op 4303014 ns/op 1.02
BenchmarkChange/Pull_100_Changes - B/op 257708 B/op 257269 B/op 1.00
BenchmarkChange/Pull_100_Changes - allocs/op 3154 allocs/op 3154 allocs/op 1
BenchmarkChange/Pull_1000_Changes - ns/op 8568016 ns/op 8473189 ns/op 1.01
BenchmarkChange/Pull_1000_Changes - B/op 1396405 B/op 1393414 B/op 1.00
BenchmarkChange/Pull_1000_Changes - allocs/op 26866 allocs/op 26869 allocs/op 1.00
BenchmarkSnapshot/Push_3KB_snapshot - ns/op 16701447 ns/op 16717315 ns/op 1.00
BenchmarkSnapshot/Push_3KB_snapshot - B/op 817649 B/op 807884 B/op 1.01
BenchmarkSnapshot/Push_3KB_snapshot - allocs/op 6543 allocs/op 6541 allocs/op 1.00
BenchmarkSnapshot/Push_30KB_snapshot - ns/op 116381444 ns/op 117501595 ns/op 0.99
BenchmarkSnapshot/Push_30KB_snapshot - B/op 6170619 B/op 6250940 B/op 0.99
BenchmarkSnapshot/Push_30KB_snapshot - allocs/op 62163 allocs/op 62161 allocs/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - ns/op 6667051 ns/op 6521588 ns/op 1.02
BenchmarkSnapshot/Pull_3KB_snapshot - B/op 904517 B/op 904310 B/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - allocs/op 14879 allocs/op 14878 allocs/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - ns/op 14979121 ns/op 15228711 ns/op 0.98
BenchmarkSnapshot/Pull_30KB_snapshot - B/op 6980488 B/op 6983077 B/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - allocs/op 144142 allocs/op 144141 allocs/op 1.00
BenchmarkSync/memory_sync_10_test - ns/op 6980 ns/op 6917 ns/op 1.01
BenchmarkSync/memory_sync_10_test - B/op 1286 B/op 1286 B/op 1
BenchmarkSync/memory_sync_10_test - allocs/op 38 allocs/op 38 allocs/op 1
BenchmarkSync/memory_sync_100_test - ns/op 52755 ns/op 51493 ns/op 1.02
BenchmarkSync/memory_sync_100_test - B/op 8635 B/op 8650 B/op 1.00
BenchmarkSync/memory_sync_100_test - allocs/op 272 allocs/op 273 allocs/op 1.00
BenchmarkSync/memory_sync_1000_test - ns/op 596305 ns/op 598451 ns/op 1.00
BenchmarkSync/memory_sync_1000_test - B/op 74336 B/op 74330 B/op 1.00
BenchmarkSync/memory_sync_1000_test - allocs/op 2110 allocs/op 2108 allocs/op 1.00
BenchmarkSync/memory_sync_10000_test - ns/op 7216018 ns/op 7141413 ns/op 1.01
BenchmarkSync/memory_sync_10000_test - B/op 763919 B/op 761330 B/op 1.00
BenchmarkSync/memory_sync_10000_test - allocs/op 20642 allocs/op 20560 allocs/op 1.00
BenchmarkTextEditing - ns/op 18670266066 ns/op 19117165431 ns/op 0.98
BenchmarkTextEditing - B/op 9037779064 B/op 9037584392 B/op 1.00
BenchmarkTextEditing - allocs/op 19922364 allocs/op 19921383 allocs/op 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.