Skip to content

Commit

Permalink
Clean up skip comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@hackerwins
hackerwins committed Aug 15, 2023
1 parent 2397d74 commit b4f0038
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
6 changes: 4 additions & 2 deletions pkg/document/crdt/tree_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,8 @@ func TestTree(t *testing.T) {
})

t.Run("delete nodes between element nodes test", func(t *testing.T) {
t.Skip()
t.Skip("TODO(hackerwins): We need to fix this test.")

// 01. Create a tree with 2 paragraphs.
// 0 1 2 3 4 5 6 7 8
// <root> <p> a b </p> <p> c d </p> </root>
Expand Down Expand Up @@ -266,7 +267,8 @@ func TestTree(t *testing.T) {
})

t.Run("style node with attributes test", func(t *testing.T) {
t.Skip()
t.Skip("TODO(hackerwins): We need to fix this test.")

// 01. style attributes to an element node.
ctx := helper.TextChangeContext(helper.TestRoot())
tree := crdt.NewTree(crdt.NewTreeNode(helper.IssuePos(ctx), "root", nil), helper.IssueTime(ctx))
Expand Down
2 changes: 1 addition & 1 deletion pkg/index/tree_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ func TestIndexTree(t *testing.T) {
})

t.Run("find treePos from given path test", func(t *testing.T) {
t.Skip("TODO(hackerwins): remove skip")
t.Skip("TODO(hackerwins): We need to fix this test")

// 0 1 2 3 4 5 6 7 8 9 10 11 12 13
// <root> <p> a b </p> <p> c d e </p> <p> f g </p> </root>
Expand Down
3 changes: 2 additions & 1 deletion test/integration/tree_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,8 @@ func TestTree(t *testing.T) {
})

t.Run("edit its content with attributes test", func(t *testing.T) {
t.Skip()
t.Skip("TODO(hackerwins): We need to fix this test.")

doc := document.New(helper.TestDocKey(t))
err := doc.Update(func(root *json.Object, p *presence.Presence) error {
root.SetNewTree("t", &json.TreeNode{Type: "doc"})
Expand Down

1 comment on commit b4f0038

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Benchmark

Benchmark suite Current: b4f0038 Previous: 1f63722 Ratio
BenchmarkDocument/constructor_test - ns/op 1558 ns/op 1571 ns/op 0.99
BenchmarkDocument/constructor_test - B/op 984 B/op 984 B/op 1
BenchmarkDocument/constructor_test - allocs/op 16 allocs/op 16 allocs/op 1
BenchmarkDocument/status_test - ns/op 1280 ns/op 889.9 ns/op 1.44
BenchmarkDocument/status_test - B/op 952 B/op 952 B/op 1
BenchmarkDocument/status_test - allocs/op 14 allocs/op 14 allocs/op 1
BenchmarkDocument/equals_test - ns/op 9064 ns/op 8561 ns/op 1.06
BenchmarkDocument/equals_test - B/op 6192 B/op 6192 B/op 1
BenchmarkDocument/equals_test - allocs/op 106 allocs/op 106 allocs/op 1
BenchmarkDocument/nested_update_test - ns/op 22869 ns/op 23849 ns/op 0.96
BenchmarkDocument/nested_update_test - B/op 11689 B/op 11689 B/op 1
BenchmarkDocument/nested_update_test - allocs/op 248 allocs/op 248 allocs/op 1
BenchmarkDocument/delete_test - ns/op 29949 ns/op 30251 ns/op 0.99
BenchmarkDocument/delete_test - B/op 14915 B/op 14915 B/op 1
BenchmarkDocument/delete_test - allocs/op 327 allocs/op 327 allocs/op 1
BenchmarkDocument/object_test - ns/op 10771 ns/op 10605 ns/op 1.02
BenchmarkDocument/object_test - B/op 6448 B/op 6448 B/op 1
BenchmarkDocument/object_test - allocs/op 110 allocs/op 110 allocs/op 1
BenchmarkDocument/array_test - ns/op 36688 ns/op 40110 ns/op 0.91
BenchmarkDocument/array_test - B/op 11546 B/op 11545 B/op 1.00
BenchmarkDocument/array_test - allocs/op 264 allocs/op 264 allocs/op 1
BenchmarkDocument/text_test - ns/op 40674 ns/op 38207 ns/op 1.06
BenchmarkDocument/text_test - B/op 14618 B/op 14618 B/op 1
BenchmarkDocument/text_test - allocs/op 470 allocs/op 470 allocs/op 1
BenchmarkDocument/text_composition_test - ns/op 38477 ns/op 38782 ns/op 0.99
BenchmarkDocument/text_composition_test - B/op 18002 B/op 18002 B/op 1
BenchmarkDocument/text_composition_test - allocs/op 471 allocs/op 471 allocs/op 1
BenchmarkDocument/rich_text_test - ns/op 102568 ns/op 103540 ns/op 0.99
BenchmarkDocument/rich_text_test - B/op 36808 B/op 36807 B/op 1.00
BenchmarkDocument/rich_text_test - allocs/op 1131 allocs/op 1131 allocs/op 1
BenchmarkDocument/counter_test - ns/op 21333 ns/op 20994 ns/op 1.02
BenchmarkDocument/counter_test - B/op 9970 B/op 9970 B/op 1
BenchmarkDocument/counter_test - allocs/op 235 allocs/op 235 allocs/op 1
BenchmarkDocument/text_edit_gc_100 - ns/op 4010346 ns/op 3963886 ns/op 1.01
BenchmarkDocument/text_edit_gc_100 - B/op 1553457 B/op 1553087 B/op 1.00
BenchmarkDocument/text_edit_gc_100 - allocs/op 17165 allocs/op 17161 allocs/op 1.00
BenchmarkDocument/text_edit_gc_1000 - ns/op 314984210 ns/op 313689090 ns/op 1.00
BenchmarkDocument/text_edit_gc_1000 - B/op 136643600 B/op 136631552 B/op 1.00
BenchmarkDocument/text_edit_gc_1000 - allocs/op 210756 allocs/op 210701 allocs/op 1.00
BenchmarkDocument/text_split_gc_100 - ns/op 4522633 ns/op 4598879 ns/op 0.98
BenchmarkDocument/text_split_gc_100 - B/op 2217658 B/op 2217588 B/op 1.00
BenchmarkDocument/text_split_gc_100 - allocs/op 16589 allocs/op 16589 allocs/op 1
BenchmarkDocument/text_split_gc_1000 - ns/op 365774226 ns/op 361375128 ns/op 1.01
BenchmarkDocument/text_split_gc_1000 - B/op 214850717 B/op 214859917 B/op 1.00
BenchmarkDocument/text_split_gc_1000 - allocs/op 211401 allocs/op 211446 allocs/op 1.00
BenchmarkDocument/text_delete_all_10000 - ns/op 19329651 ns/op 19578579 ns/op 0.99
BenchmarkDocument/text_delete_all_10000 - B/op 5904920 B/op 5904621 B/op 1.00
BenchmarkDocument/text_delete_all_10000 - allocs/op 41129 allocs/op 41128 allocs/op 1.00
BenchmarkDocument/text_delete_all_100000 - ns/op 311975430 ns/op 254618054 ns/op 1.23
BenchmarkDocument/text_delete_all_100000 - B/op 53839226 B/op 53839944 B/op 1.00
BenchmarkDocument/text_delete_all_100000 - allocs/op 415980 allocs/op 415993 allocs/op 1.00
BenchmarkDocument/text_100 - ns/op 320593 ns/op 330774 ns/op 0.97
BenchmarkDocument/text_100 - B/op 118211 B/op 118213 B/op 1.00
BenchmarkDocument/text_100 - allocs/op 5074 allocs/op 5074 allocs/op 1
BenchmarkDocument/text_1000 - ns/op 3641678 ns/op 3639084 ns/op 1.00
BenchmarkDocument/text_1000 - B/op 1152796 B/op 1152823 B/op 1.00
BenchmarkDocument/text_1000 - allocs/op 50078 allocs/op 50078 allocs/op 1
BenchmarkDocument/array_1000 - ns/op 1824855 ns/op 1797916 ns/op 1.01
BenchmarkDocument/array_1000 - B/op 1102713 B/op 1102821 B/op 1.00
BenchmarkDocument/array_1000 - allocs/op 11867 allocs/op 11867 allocs/op 1
BenchmarkDocument/array_10000 - ns/op 20716107 ns/op 20787542 ns/op 1.00
BenchmarkDocument/array_10000 - B/op 9907254 B/op 9907150 B/op 1.00
BenchmarkDocument/array_10000 - allocs/op 120721 allocs/op 120719 allocs/op 1.00
BenchmarkDocument/array_gc_100 - ns/op 185361 ns/op 183158 ns/op 1.01
BenchmarkDocument/array_gc_100 - B/op 98165 B/op 98169 B/op 1.00
BenchmarkDocument/array_gc_100 - allocs/op 1243 allocs/op 1243 allocs/op 1
BenchmarkDocument/array_gc_1000 - ns/op 2059153 ns/op 1976201 ns/op 1.04
BenchmarkDocument/array_gc_1000 - B/op 1170360 B/op 1170344 B/op 1.00
BenchmarkDocument/array_gc_1000 - allocs/op 12906 allocs/op 12906 allocs/op 1
BenchmarkDocument/counter_1000 - ns/op 290384 ns/op 285428 ns/op 1.02
BenchmarkDocument/counter_1000 - B/op 198532 B/op 198534 B/op 1.00
BenchmarkDocument/counter_1000 - allocs/op 6503 allocs/op 6503 allocs/op 1
BenchmarkDocument/counter_10000 - ns/op 3090829 ns/op 3095974 ns/op 1.00
BenchmarkDocument/counter_10000 - B/op 2165457 B/op 2165456 B/op 1.00
BenchmarkDocument/counter_10000 - allocs/op 69510 allocs/op 69510 allocs/op 1
BenchmarkDocument/object_1000 - ns/op 1899305 ns/op 1901665 ns/op 1.00
BenchmarkDocument/object_1000 - B/op 1451299 B/op 1451351 B/op 1.00
BenchmarkDocument/object_1000 - allocs/op 9915 allocs/op 9915 allocs/op 1
BenchmarkDocument/object_10000 - ns/op 22565080 ns/op 23966450 ns/op 0.94
BenchmarkDocument/object_10000 - B/op 12371534 B/op 12371453 B/op 1.00
BenchmarkDocument/object_10000 - allocs/op 101226 allocs/op 101226 allocs/op 1
BenchmarkRPC/client_to_server - ns/op 408415576 ns/op 401201105 ns/op 1.02
BenchmarkRPC/client_to_server - B/op 12271568 B/op 12262480 B/op 1.00
BenchmarkRPC/client_to_server - allocs/op 177232 allocs/op 177181 allocs/op 1.00
BenchmarkRPC/client_to_client_via_server - ns/op 683614294 ns/op 685664009 ns/op 1.00
BenchmarkRPC/client_to_client_via_server - B/op 22569636 B/op 22584304 B/op 1.00
BenchmarkRPC/client_to_client_via_server - allocs/op 330238 allocs/op 330481 allocs/op 1.00
BenchmarkRPC/attach_large_document - ns/op 1573138148 ns/op 1473754095 ns/op 1.07
BenchmarkRPC/attach_large_document - B/op 1798891744 B/op 1819078872 B/op 0.99
BenchmarkRPC/attach_large_document - allocs/op 9614 allocs/op 9660 allocs/op 1.00
BenchmarkRPC/adminCli_to_server - ns/op 590668199 ns/op 559190893 ns/op 1.06
BenchmarkRPC/adminCli_to_server - B/op 20392760 B/op 20410700 B/op 1.00
BenchmarkRPC/adminCli_to_server - allocs/op 321611 allocs/op 321614 allocs/op 1.00
BenchmarkLocker - ns/op 131.3 ns/op 123.1 ns/op 1.07
BenchmarkLocker - B/op 16 B/op 16 B/op 1
BenchmarkLocker - allocs/op 1 allocs/op 1 allocs/op 1
BenchmarkLockerParallel - ns/op 133.3 ns/op 126.5 ns/op 1.05
BenchmarkLockerParallel - B/op 0 B/op 0 B/op NaN
BenchmarkLockerParallel - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkLockerMoreKeys - ns/op 318.2 ns/op 440.8 ns/op 0.72
BenchmarkLockerMoreKeys - B/op 14 B/op 13 B/op 1.08
BenchmarkLockerMoreKeys - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkSync/memory_sync_10_test - ns/op 7226 ns/op 7461 ns/op 0.97
BenchmarkSync/memory_sync_10_test - B/op 1285 B/op 1283 B/op 1.00
BenchmarkSync/memory_sync_10_test - allocs/op 38 allocs/op 38 allocs/op 1
BenchmarkSync/memory_sync_100_test - ns/op 66880 ns/op 69442 ns/op 0.96
BenchmarkSync/memory_sync_100_test - B/op 8864 B/op 8763 B/op 1.01
BenchmarkSync/memory_sync_100_test - allocs/op 287 allocs/op 280 allocs/op 1.02
BenchmarkSync/memory_sync_1000_test - ns/op 704140 ns/op 699971 ns/op 1.01
BenchmarkSync/memory_sync_1000_test - B/op 81958 B/op 81716 B/op 1.00
BenchmarkSync/memory_sync_1000_test - allocs/op 2590 allocs/op 2579 allocs/op 1.00
BenchmarkSync/memory_sync_10000_test - ns/op 7465689 ns/op 7491717 ns/op 1.00
BenchmarkSync/memory_sync_10000_test - B/op 861386 B/op 850438 B/op 1.01
BenchmarkSync/memory_sync_10000_test - allocs/op 26743 allocs/op 26946 allocs/op 0.99
BenchmarkTextEditing - ns/op 28369901703 ns/op 27697786985 ns/op 1.02
BenchmarkTextEditing - B/op 8457447136 B/op 8457437952 B/op 1.00
BenchmarkTextEditing - allocs/op 20616897 allocs/op 20616814 allocs/op 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.